fix(core): add back target defaults for all new workspaces (nrwl#11936)

moQuez · Sep 8, 2022 · caec117 · caec117
1 parent ae58c1d
commit caec117
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/e2e/nx-run/src/cache.test.ts b/e2e/nx-run/src/cache.test.ts
@@ -64,9 +64,9 @@ describe('cache', () => {
 
     // touch package.json
     // --------------------------------------------
-    updateFile(`package.json`, (c) => {
+    updateFile(`nx.json`, (c) => {
       const r = JSON.parse(c);
-      r.description = 'different';
+      r.affected.defaultBase = 'different';
       return JSON.stringify(r);
     });
     const outputWithNoBuildCached = runCLI(`affected:build ${files}`);

diff --git a/packages/workspace/src/generators/workspace/workspace.spec.ts b/packages/workspace/src/generators/workspace/workspace.spec.ts
@@ -53,6 +53,11 @@ describe('@nrwl/workspace:workspace', () => {
           },
         },
       },
+      targetDefaults: {
+        build: {
+          dependsOn: ['^build'],
+        },
+      },
     });
     const validateNxJson = ajv.compile(nxSchema);
     expect(validateNxJson(nxJson)).toEqual(true);

diff --git a/packages/workspace/src/generators/workspace/workspace.ts b/packages/workspace/src/generators/workspace/workspace.ts
@@ -80,6 +80,12 @@ function createNxJson(
     },
   };
 
+  nxJson.targetDefaults = {
+    build: {
+      dependsOn: ['^build'],
+    },
+  };
+
   if (
     preset !== Preset.Core &&
     preset !== Preset.NPM &&
@@ -90,12 +96,7 @@ function createNxJson(
       production: ['default'],
       sharedGlobals: [],
     };
-    nxJson.targetDefaults = {
-      build: {
-        dependsOn: ['^build'],
-        inputs: ['production', '^production'],
-      },
-    };
+    nxJson.targetDefaults.build.inputs = ['production', '^production'];
   }
 
   if (packageManager && cli === 'angular') {