Feature Movie/Show trailers #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moallemi
previously approved these changes
Sep 23, 2024
Comment on lines
+22
to
+32
| companion object { | ||
| const val YOUTUBE_WATCH_PAGE = "https://youtube.com/watch?v=" | ||
| const val YOUTUBE_THUMBNAIL_URL = "https://img.youtube.com/vi/{id}/hqdefault.jpg" | ||
| } | ||
|
|
There was a problem hiding this comment.
💅 Better to move it to the end of the class
https://kotlinlang.org/docs/coding-conventions.html#class-layout
Comment on lines
+25
to
+35
| companion object { | ||
| const val YOUTUBE_WATCH_PAGE = "https://youtube.com/watch?v=" | ||
| const val YOUTUBE_THUMBNAIL_URL = "https://img.youtube.com/vi/{id}/hqdefault.jpg" | ||
| } | ||
|
|
There was a problem hiding this comment.
💅 Better to move it to the end of the class
https://kotlinlang.org/docs/coding-conventions.html#class-layout
| .fillMaxWidth() | ||
| .wrapContentSize(), | ||
| ) | ||
| } else if (items.isNotEmpty()) { |
There was a problem hiding this comment.
Need to handle no trailers state
Comment on lines
59
to
70
| Box( | ||
| modifier = Modifier | ||
| .align(Alignment.BottomCenter) | ||
| .fillMaxWidth() | ||
| .background(Color.Black.copy(alpha = 0.7f)) | ||
| .padding(4.dp), | ||
| ) { | ||
| Text( | ||
| modifier = Modifier | ||
| .padding(horizontal = 12.dp, vertical = 4.dp), | ||
| text = video.name, | ||
| style = MaterialTheme.typography.titleMedium, | ||
| overflow = TextOverflow.Ellipsis, | ||
| minLines = 1, | ||
| maxLines = 3, | ||
| ) | ||
| } | ||
| } |
Comment on lines
121
to
132
| val body = result.body | ||
| if (body == null) { | ||
| Result.Failure(GeneralError.UnknownError(Throwable("Videos is null"))) | ||
| } | ||
| Result.Success(body!!.results.map { it.toVideos() }) | ||
| } |
There was a problem hiding this comment.
Line 125 will always crash if body == null, you forgot to add if/else
| if (body == null) { | ||
| Result.Failure(GeneralError.UnknownError(Throwable("Videos is null"))) | ||
| } | ||
| Result.Success(body!!.results.map { it.toVideos() }) |
There was a problem hiding this comment.
Line 140 will always crash if body == null, you forgot to add if/else
moallemi
force-pushed
the
feature/trailers
branch
from
cecde1b to
3295f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly.
Take a look at the contributing guidelines for this project.
Description
Checklist
Fixes #<issue_number_goes_here>