Skip to content

Commit

Permalink
driconf: add executable_regexp application attribute
Browse files Browse the repository at this point in the history
For matching executable with variable names like Mari which
append version string to its executable like: Mari4.5v2, Mari4.7v4.

Reviewed-by: Marek Olšák <[email protected]>
Signed-off-by: Qiang Yu <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13304>
  • Loading branch information
yuq authored and Marge Bot committed Nov 2, 2021
1 parent 308bd1f commit 9a24de9
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/util/00-mesa-defaults.conf
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ TODO: document the other workarounds.
<!ELEMENT application (option+)>
<!ATTLIST application name CDATA #REQUIRED
executable CDATA #IMPLIED
executable_regexp CDATA #IMPLIED
sha1 CDATA #IMPLIED
application_name_match CDATA #IMPLIED
application_versions CDATA #IMPLIED>
Expand Down
11 changes: 11 additions & 0 deletions src/util/xmlconfig.c
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,7 @@ parseAppAttr(struct OptConfData *data, const char **attr)
uint32_t i;
const char *exec = NULL;
const char *sha1 = NULL;
const char *exec_regexp = NULL;
const char *application_name_match = NULL;
const char *application_versions = NULL;
driOptionInfo version_range = {
Expand All @@ -690,6 +691,7 @@ parseAppAttr(struct OptConfData *data, const char **attr)
for (i = 0; attr[i]; i += 2) {
if (!strcmp(attr[i], "name")) /* not needed here */;
else if (!strcmp(attr[i], "executable")) exec = attr[i+1];
else if (!strcmp(attr[i], "executable_regexp")) exec_regexp = attr[i+1];
else if (!strcmp(attr[i], "sha1")) sha1 = attr[i+1];
else if (!strcmp(attr[i], "application_name_match"))
application_name_match = attr[i+1];
Expand All @@ -699,6 +701,15 @@ parseAppAttr(struct OptConfData *data, const char **attr)
}
if (exec && strcmp(exec, data->execName)) {
data->ignoringApp = data->inApp;
} else if (exec_regexp) {
regex_t re;

if (regcomp(&re, exec_regexp, REG_EXTENDED|REG_NOSUB) == 0) {
if (regexec(&re, data->execName, 0, NULL, 0) == REG_NOMATCH)
data->ignoringApp = data->inApp;
regfree(&re);
} else
XML_WARNING("Invalid executable_regexp=\"%s\".", exec_regexp);
} else if (sha1) {
/* SHA1_DIGEST_STRING_LENGTH includes terminating null byte */
if (strlen(sha1) != (SHA1_DIGEST_STRING_LENGTH - 1)) {
Expand Down

0 comments on commit 9a24de9

Please sign in to comment.