Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mc-util-vec-map which exposes a heapless map type #2810

Merged
merged 8 commits into from
Nov 3, 2022
Merged

Conversation

cbeck88
Copy link
Contributor

@cbeck88 cbeck88 commented Nov 2, 2022

A heapless map type is needed for things like hardware wallets.

This was pulled out of #2725 to ease review.

This was mainly used to do POC work and evaluate how much stack space the TxSummary streaming verifier would actually use. But in the future it could become production code I think, we'll have to see.

A heapless map type is needed for things like hardware wallets.

This was pulled out of #2725 to ease review.
@cbeck88 cbeck88 requested review from jcape, remoun, eranrund, a team, isis-mc and ryankurte November 2, 2022 03:54
util/vec-map/README.md Outdated Show resolved Hide resolved
util/vec-map/src/lib.rs Outdated Show resolved Hide resolved
util/vec-map/src/lib.rs Outdated Show resolved Hide resolved
util/vec-map/src/lib.rs Show resolved Hide resolved
util/vec-map/src/lib.rs Outdated Show resolved Hide resolved
util/vec-map/src/lib.rs Outdated Show resolved Hide resolved
util/vec-map/src/lib.rs Show resolved Hide resolved
util/vec-map/src/lib.rs Outdated Show resolved Hide resolved
util/vec-map/src/lib.rs Outdated Show resolved Hide resolved
@cbeck88 cbeck88 requested a review from a team November 2, 2022 18:27
Copy link
Contributor

@eranrund eranrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Got some small comments/questions but after that I will approve. Thanks!

util/vec-map/src/lib.rs Show resolved Hide resolved
util/vec-map/src/lib.rs Show resolved Hide resolved
util/vec-map/src/lib.rs Show resolved Hide resolved
util/vec-map/src/lib.rs Show resolved Hide resolved
util/vec-map/src/lib.rs Show resolved Hide resolved
util/vec-map/src/lib.rs Outdated Show resolved Hide resolved
util/vec-map/src/lib.rs Outdated Show resolved Hide resolved
util/vec-map/src/lib.rs Show resolved Hide resolved
@cbeck88 cbeck88 requested review from eranrund and remoun November 3, 2022 19:45
@cbeck88 cbeck88 merged commit 6b17c72 into master Nov 3, 2022
@cbeck88 cbeck88 deleted the util-vec-map branch November 3, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants