Skip to content

Commit

Permalink
Move tests with external servers to outerloop (dotnet/corefx#37934)
Browse files Browse the repository at this point in the history
* move tests with external servers to outerloop

* fix Set_ValidValues_Success


Commit migrated from dotnet/corefx@d58a8ad
  • Loading branch information
wfurt authored and davidsh committed May 27, 2019
1 parent cf437b9 commit ed528dc
Showing 1 changed file with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,7 @@ public void Set_ValidValues_Success(int validValue)
{
using (HttpClientHandler handler = CreateHttpClientHandler())
{
try
{
handler.MaxConnectionsPerServer = validValue;
}
catch (PlatformNotSupportedException)
{
// Some older libcurls used in some of our Linux CI systems don't support this
Assert.True(RuntimeInformation.IsOSPlatform(OSPlatform.Linux));
}
handler.MaxConnectionsPerServer = validValue;
}
}

Expand All @@ -71,6 +63,7 @@ public void Set_ValidValues_Success(int validValue)
[InlineData(3, 2, false)]
[InlineData(3, 2, true)]
[InlineData(3, 5, false)]
[OuterLoop("Uses external servers")]
public async Task GetAsync_MaxLimited_ConcurrentCallsStillSucceed(int maxConnections, int numRequests, bool secure)
{
using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

0 comments on commit ed528dc

Please sign in to comment.