Skip to content

Commit

Permalink
Revert "scsi: lpfc: ls_rjt erroneus FLOGIs"
Browse files Browse the repository at this point in the history
This reverts commit 287aba2.

We killed the bad firmware and this mod is no longer necessary.

Signed-off-by: James Smart <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
  • Loading branch information
martinkpetersen committed Dec 13, 2018
1 parent de55b78 commit 2d1036a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 21 deletions.
20 changes: 0 additions & 20 deletions drivers/scsi/lpfc/lpfc_els.c
Original file line number Diff line number Diff line change
Expand Up @@ -8091,10 +8091,8 @@ lpfc_els_unsol_buffer(struct lpfc_hba *phba, struct lpfc_sli_ring *pring,
struct ls_rjt stat;
uint32_t *payload;
uint32_t cmd, did, newnode;
uint32_t vid, flag;
uint8_t rjt_exp, rjt_err = 0, init_link = 0;
IOCB_t *icmd = &elsiocb->iocb;
struct serv_parm *sp;
LPFC_MBOXQ_t *mbox;

if (!vport || !(elsiocb->context2))
Expand Down Expand Up @@ -8245,22 +8243,6 @@ lpfc_els_unsol_buffer(struct lpfc_hba *phba, struct lpfc_sli_ring *pring,
did, vport->port_state, ndlp->nlp_flag);

phba->fc_stat.elsRcvFLOGI++;
sp = (struct serv_parm *)
((uint8_t *)payload + sizeof(uint32_t));

/* Check to see if this is firmware generated */
if (sp->cmn.valid_vendor_ver_level) {
vid = be32_to_cpu(sp->un.vv.vid);
flag = be32_to_cpu(sp->un.vv.flags);
if (vid == LPFC_VV_BRCD_ID) {
/* Drop this FLOGI */
lpfc_printf_vlog(
vport, KERN_INFO, LOG_ELS,
"3316 Dropping rcv FLOGI: "
"flag x%x\n", flag);
goto lsrjt;
}
}

/* If the driver believes fabric discovery is done and is ready,
* bounce the link. There is some descrepancy.
Expand Down Expand Up @@ -8508,8 +8490,6 @@ lpfc_els_unsol_buffer(struct lpfc_hba *phba, struct lpfc_sli_ring *pring,
* link and start over.
*/
if (init_link) {
lpfc_printf_vlog(vport, KERN_ERR, LOG_ELS,
"3318 Resetting Link, multiple rcv FLOGIs\n");
mbox = mempool_alloc(phba->mbox_mem_pool, GFP_KERNEL);
if (!mbox)
return;
Expand Down
1 change: 0 additions & 1 deletion drivers/scsi/lpfc/lpfc_hw.h
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,6 @@ struct serv_parm { /* Structure is in Big Endian format */
struct {
uint32_t vid;
#define LPFC_VV_EMLX_ID 0x454d4c58 /* EMLX */
#define LPFC_VV_BRCD_ID 0x42524344 /* BRCD */
uint32_t flags;
#define LPFC_VV_SUPPRESS_RSP 1
} vv;
Expand Down

0 comments on commit 2d1036a

Please sign in to comment.