Skip to content

Commit

Permalink
drm/vmwgfx: Also check for crtc status while checking for DU active
Browse files Browse the repository at this point in the history
During modeset check it is possible to have all crtc_state's in atomic
state. Check for crtc enable status while checking for display unit
active status. Only error if enabling a crtc while display unit is not
active.

Cc: <[email protected]>
Fixes: 9da6e26: ("drm/vmwgfx: Fix a layout race condition")
Signed-off-by: Deepak Rawat <[email protected]>
Reviewed-by: Thomas Hellstrom <[email protected]>
Signed-off-by: Thomas Hellstrom <[email protected]>
  • Loading branch information
deepak-rawat authored and thomashvmw committed Feb 5, 2019
1 parent 51fdbeb commit 479d590
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
Original file line number Diff line number Diff line change
Expand Up @@ -1646,7 +1646,7 @@ static int vmw_kms_check_topology(struct drm_device *dev,
struct drm_connector_state *conn_state;
struct vmw_connector_state *vmw_conn_state;

if (!du->pref_active) {
if (!du->pref_active && new_crtc_state->enable) {
ret = -EINVAL;
goto clean;
}
Expand Down

0 comments on commit 479d590

Please sign in to comment.