Skip to content

Commit

Permalink
lib/test_sort.c: make it explicitly non-modular
Browse files Browse the repository at this point in the history
The Kconfig currently controlling compilation of this code is:

     lib/Kconfig.debug:config TEST_SORT
     lib/Kconfig.debug:      bool "Array-based sort test"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modular infrastructure use, so that
when reading the code there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular case,
the init ordering becomes slightly earlier when we change it to use
subsys_initcall as done here.  However, since it is a self contained
test, this shouldn't be an issue and subsys_initcall seems like a better
fit for this particular case.

We also delete the MODULE_LICENSE tag since that information is now
contained at the top of the file in the comments.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Paul Gortmaker <[email protected]>
Cc: Kostenzer Felix <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Paul Gortmaker authored and torvalds committed Feb 25, 2017
1 parent c5adae9 commit 8893f51
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions lib/test_sort.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
#include <linux/sort.h>
#include <linux/slab.h>
#include <linux/module.h>
#include <linux/init.h>

/* a simple boot-time regression test */
/*
* A simple boot-time regression test
* License: GPL
*/

#define TEST_LEN 1000

Expand Down Expand Up @@ -38,6 +41,4 @@ static int __init test_sort_init(void)
kfree(a);
return err;
}

module_init(test_sort_init);
MODULE_LICENSE("GPL");
subsys_initcall(test_sort_init);

0 comments on commit 8893f51

Please sign in to comment.