bfs_lookup(): use d_splice_alias()

code is actually simpler that way. Acked-by: "Tigran A. Aivazian" <[email protected]> Signed-off-by: Al Viro <[email protected]>
modi0012 · May 22, 2018 · a596a23 · a596a23
1 parent 837f3ec
commit a596a23
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c
@@ -141,14 +141,9 @@ static struct dentry *bfs_lookup(struct inode *dir, struct dentry *dentry,
 		unsigned long ino = (unsigned long)le16_to_cpu(de->ino);
 		brelse(bh);
 		inode = bfs_iget(dir->i_sb, ino);
-		if (IS_ERR(inode)) {
-			mutex_unlock(&info->bfs_lock);
-			return ERR_CAST(inode);
-		}
 	}
 	mutex_unlock(&info->bfs_lock);
-	d_add(dentry, inode);
-	return NULL;
+	return d_splice_alias(inode, dentry);
 }
 
 static int bfs_link(struct dentry *old, struct inode *dir,