Skip to content

Commit

Permalink
btrfs: Remove unused -EIO assignment in end_bio_extent_readpage
Browse files Browse the repository at this point in the history
In case we hit the error case for a metadata buffer in
end_bio_extent_readpage then 'ret' won't really be checked before it's
written again to. This means the -EIO in this case will never be
checked, just remove it.

Fixes-coverity-id: 1442513
Signed-off-by: Nikolay Borisov <[email protected]>
Reviewed-by: David Sterba <[email protected]>
Signed-off-by: David Sterba <[email protected]>
  • Loading branch information
lorddoskias authored and kdave committed Apr 29, 2019
1 parent e65ef21 commit d51f51b
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions fs/btrfs/extent_io.c
Original file line number Diff line number Diff line change
Expand Up @@ -2614,8 +2614,6 @@ static void end_bio_extent_readpage(struct bio *bio)
if (test_and_clear_bit(EXTENT_BUFFER_READAHEAD,
&eb->bflags))
btree_readahead_hook(eb, -EIO);

ret = -EIO;
}
readpage_ok:
if (likely(uptodate)) {
Expand Down

0 comments on commit d51f51b

Please sign in to comment.