Skip to content

Commit

Permalink
Symbols are not scoped.
Browse files Browse the repository at this point in the history
  • Loading branch information
gollux committed Nov 4, 1999
1 parent 9144796 commit c8f61a0
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 1 deletion.
31 changes: 30 additions & 1 deletion conf/cf-lex.l
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ static struct keyword {
static struct keyword *kw_hash[KW_HASH_SIZE];
static struct symbol **sym_hash;

struct sym_scope {
struct sym_scope *next; /* Next on scope stack */
struct symbol *name; /* Name of this scope */
int active; /* Currently entered */
};
static struct sym_scope *conf_this_scope;

int conf_lino;

static int cf_hash(byte *c);
Expand Down Expand Up @@ -184,14 +191,15 @@ cf_find_sym(byte *c, unsigned int h0)
sym_hash = cfg_allocz(SYM_HASH_SIZE * sizeof(struct keyword *));
else
for(s = sym_hash[h]; s; s=s->next)
if (!strcmp(s->name, c))
if (!strcmp(s->name, c) && s->scope->active)
return s;
l = strlen(c);
if (l > SYM_MAX_LEN)
cf_error("Symbol too long");
s = cfg_alloc(sizeof(struct symbol) + l);
s->next = sym_hash[h];
sym_hash[h] = s;
s->scope = conf_this_scope;
s->class = SYM_VOID;
s->def = NULL;
s->aux = 0;
Expand Down Expand Up @@ -240,6 +248,8 @@ cf_lex_init(int is_cli)
BEGIN(CLI);
else
BEGIN(INITIAL);
conf_this_scope = cfg_allocz(sizeof(struct sym_scope));
conf_this_scope->active = 1;
}

void
Expand All @@ -254,3 +264,22 @@ cf_lex_init_tables(void)
kw_hash[h] = k;
}
}

void
cf_push_scope(struct symbol *sym)
{
struct sym_scope *s = cfg_alloc(sizeof(struct sym_scope));

s->next = conf_this_scope;
conf_this_scope = s;
s->active = 1;
s->name = sym;
}

void
cf_pop_scope(void)
{
conf_this_scope->active = 0;
conf_this_scope = conf_this_scope->next;
ASSERT(conf_this_scope);
}
3 changes: 3 additions & 0 deletions conf/conf.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ extern int (*cf_read_hook)(byte *buf, unsigned int max);

struct symbol {
struct symbol *next;
struct sym_scope *scope;
int class;
int aux;
void *aux2;
Expand All @@ -75,6 +76,8 @@ void cf_lex_init(int is_cli);
struct symbol *cf_find_symbol(byte *c);
struct symbol *cf_default_name(char *prefix, int *counter);
void cf_define_symbol(struct symbol *symbol, int type, void *def);
void cf_push_context(struct symbol *);
void cf_pop_context(void);

/* Parser */

Expand Down

0 comments on commit c8f61a0

Please sign in to comment.