Skip to content

Commit

Permalink
Rebuild HPACK encoder table as C++ (grpc#27192)
Browse files Browse the repository at this point in the history
* Rebuild HPACK encoder table as C++

* move comment

* incguards

* build

* Automated change: Fix sanity tests

* c++ initialization ftw

* Automated change: Fix sanity tests

* Add missing header

* Add missing header

Co-authored-by: ctiller <[email protected]>
  • Loading branch information
ctiller and ctiller authored Sep 2, 2021
1 parent 4729f6f commit 999e36f
Show file tree
Hide file tree
Showing 31 changed files with 612 additions and 310 deletions.
37 changes: 35 additions & 2 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2826,6 +2826,17 @@ grpc_cc_library(
],
)

grpc_cc_library(
name = "hpack_constants",
hdrs = [
"src/core/ext/transport/chttp2/transport/hpack_constants.h",
],
language = "c++",
deps = [
"gpr_platform",
],
)

grpc_cc_library(
name = "hpack_encoder_index",
hdrs = [
Expand All @@ -2840,6 +2851,24 @@ grpc_cc_library(
],
)

grpc_cc_library(
name = "hpack_encoder_table",
srcs = [
"src/core/ext/transport/chttp2/transport/hpack_encoder_table.cc",
],
hdrs = [
"src/core/ext/transport/chttp2/transport/hpack_encoder_table.h",
],
external_deps = [
"absl/container:inlined_vector",
],
language = "c++",
deps = [
"gpr",
"hpack_constants",
],
)

grpc_cc_library(
name = "grpc_transport_chttp2",
srcs = [
Expand All @@ -2858,7 +2887,8 @@ grpc_cc_library(
"src/core/ext/transport/chttp2/transport/frame_window_update.cc",
"src/core/ext/transport/chttp2/transport/hpack_encoder.cc",
"src/core/ext/transport/chttp2/transport/hpack_parser.cc",
"src/core/ext/transport/chttp2/transport/hpack_table.cc",
"src/core/ext/transport/chttp2/transport/hpack_parser_table.cc",
"src/core/ext/transport/chttp2/transport/hpack_utils.cc",
"src/core/ext/transport/chttp2/transport/http2_settings.cc",
"src/core/ext/transport/chttp2/transport/huffsyms.cc",
"src/core/ext/transport/chttp2/transport/incoming_metadata.cc",
Expand All @@ -2884,7 +2914,8 @@ grpc_cc_library(
"src/core/ext/transport/chttp2/transport/frame_window_update.h",
"src/core/ext/transport/chttp2/transport/hpack_encoder.h",
"src/core/ext/transport/chttp2/transport/hpack_parser.h",
"src/core/ext/transport/chttp2/transport/hpack_table.h",
"src/core/ext/transport/chttp2/transport/hpack_parser_table.h",
"src/core/ext/transport/chttp2/transport/hpack_utils.h",
"src/core/ext/transport/chttp2/transport/http2_settings.h",
"src/core/ext/transport/chttp2/transport/huffsyms.h",
"src/core/ext/transport/chttp2/transport/incoming_metadata.h",
Expand All @@ -2907,7 +2938,9 @@ grpc_cc_library(
"grpc_http_filters",
"grpc_trace",
"grpc_transport_chttp2_alpn",
"hpack_constants",
"hpack_encoder_index",
"hpack_encoder_table",
"match",
"popularity_count",
],
Expand Down
26 changes: 15 additions & 11 deletions CMakeLists.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions Makefile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 18 additions & 8 deletions build_autogenerated.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion config.m4

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion config.w32

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 8 additions & 2 deletions gRPC-C++.podspec

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 11 additions & 3 deletions gRPC-Core.podspec

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions grpc.gemspec

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 999e36f

Please sign in to comment.