Enable Lint/StringConversionInInterpolation rubocop rule

To prevent redundant `to_s` like rails#32923 (comment) automatically in the future.
mohits · May 21, 2018 · a77447f · a77447f
1 parent 15d00f0
commit a77447f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -162,6 +162,9 @@ Style/UnneededPercentQ:
 Lint/RequireParentheses:
   Enabled: true
 
+Lint/StringConversionInInterpolation:
+  Enabled: true
+
 Style/RedundantReturn:
   Enabled: true
   AllowMultipleReturnValues: true

diff --git a/activerecord/lib/active_record/log_subscriber.rb b/activerecord/lib/active_record/log_subscriber.rb
@@ -104,7 +104,7 @@ def log_query_source
 
         if source_line
           if defined?(::Rails.root)
-            app_root = "#{::Rails.root.to_s}/".freeze
+            app_root = "#{::Rails.root}/"
             source_line = source_line.sub(app_root, "")
           end
 

diff --git a/activerecord/test/cases/arel/support/fake_record.rb b/activerecord/test/cases/arel/support/fake_record.rb
@@ -51,11 +51,11 @@ def columns(name, message = nil)
     end
 
     def quote_table_name(name)
-      "\"#{name.to_s}\""
+      "\"#{name}\""
     end
 
     def quote_column_name(name)
-      "\"#{name.to_s}\""
+      "\"#{name}\""
     end
 
     def schema_cache

diff --git a/railties/test/application/server_test.rb b/railties/test/application/server_test.rb
@@ -36,7 +36,7 @@ def teardown
       skip "PTY unavailable" unless available_pty?
 
       File.open("#{app_path}/config/boot.rb", "w") do |f|
-        f.puts "ENV['BUNDLE_GEMFILE'] = '#{Bundler.default_gemfile.to_s}'"
+        f.puts "ENV['BUNDLE_GEMFILE'] = '#{Bundler.default_gemfile}'"
         f.puts "require 'bundler/setup'"
       end