Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape column name #168

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Escape column name #168

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
463368b
escape column name
Jul 14, 2022
dd67ee1
not escape, quote
Jul 14, 2022
363d225
test for quoted fields in tmodel
Jul 18, 2022
9c677bc
Add changelog entry and bump version
Jul 19, 2022
12cf790
ok, no version bump, then
Jul 19, 2022
44af681
#159 fixed tdbtypes test for postgres
PhilippMDoerner Aug 22, 2022
5638632
#159 fixed case-sensitive test error
PhilippMDoerner Aug 22, 2022
31e113d
#159 fixed createTables not escaping field names properly
PhilippMDoerner Aug 22, 2022
146c0ab
#159 escaped fieldnames in tests
PhilippMDoerner Aug 22, 2022
63a14f5
#159 Removed quotes for foreign key constraints based on model fields
PhilippMDoerner Aug 22, 2022
efe9499
Apparently the FK field and ONLY the FK field "favToy" must be in quo…
PhilippMDoerner Aug 22, 2022
bec9c0f
The field comparison is case sensitive for some reason?
PhilippMDoerner Aug 22, 2022
502e34e
Merge branch 'develop' into escape_column_name
PhilippMDoerner Aug 22, 2022
5ebf1d3
#159 Removed some unnecessary changes I made for debugging
PhilippMDoerner Aug 23, 2022
fc6ade8
Removed dangerous inconsistent behaviour for Foreign Key constraint g…
PhilippMDoerner Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#159 fixed case-sensitive test error 
On linux, databases tend to be case-sensitive with their tests.
This test failed in part because the column is `userId` not `userid`
  • Loading branch information
@PhilippMDoerner
PhilippMDoerner committed Aug 22, 2022
commit 5638632b4a111c889f639a6c2d5d03bf7f1130ba
2 changes: 1 addition & 1 deletion tests/postgres/tfkpragma.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,6 @@ suite "``fk`` pragma":
for inpCustomer in inpCustomers.mitems:
dbConn.insert inpCustomer

dbConn.select(outCustomers, """"userid" = $1""", userA.id)
dbConn.select(outCustomers, """"userId" = $1""", userA.id)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example for sudden case-sensitivity, though that is when comparing column names and not during actual queries, not sure how much that matters.


check outCustomers === inpCustomers[0..^2]