Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-47563: Update Diagrams & Entities page #233

Open
wants to merge 2 commits into
base: docs-uplift
Choose a base branch
from

Conversation

mayaraman19
Copy link
Collaborator

@mayaraman19 mayaraman19 commented Mar 19, 2025

DESCRIPTION

Adds description of diagrams.

STAGING

https://deploy-preview-233--docs-relational-migrator.netlify.app/diagrams/

JIRA

https://jira.mongodb.org/browse/DOCSP-47563

BUILD LOG

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for docs-relational-migrator ready!

Name Link
🔨 Latest commit 8d87afd
🔍 Latest deploy log https://app.netlify.com/sites/docs-relational-migrator/deploys/67db01706069f10008d54a63
😎 Deploy Preview https://deploy-preview-233--docs-relational-migrator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28 (🔴 down 57 from production)
Accessibility: 85 (🔴 down 13 from production)
Best Practices: 75 (no change from production)
SEO: 75 (🔴 down 17 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@gmiller-mdb gmiller-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

@@ -10,6 +10,9 @@ Diagrams
:depth: 2
:class: singlecol

**Diagrams** in Relational Migrator are entity-relationship diagrams (ERDs).
The term "entity" refers to either a table in the relational model,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[s] I don't think a comma is necessary here

@jwilson-mdb
Copy link
Collaborator

LGTM'd in review session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants