Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Netty benchmark suite. #1647

Merged
merged 15 commits into from
Apr 2, 2025
Merged

Introduce Netty benchmark suite. #1647

merged 15 commits into from
Apr 2, 2025

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin commented Mar 13, 2025

Depends on #1646 [Merged]

JAVA-5813

@vbabanin vbabanin self-assigned this Mar 13, 2025
@vbabanin vbabanin requested review from a team, nhachicha, stIncMale and rozza and removed request for a team, nhachicha and stIncMale March 19, 2025 01:46
@vbabanin vbabanin marked this pull request as ready for review March 19, 2025 18:28
@vbabanin vbabanin marked this pull request as draft March 19, 2025 18:34
# Conflicts:
#	driver-benchmarks/build.gradle
@vbabanin vbabanin marked this pull request as ready for review March 27, 2025 05:29
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just some merge conflicts to fix.

# Conflicts:
#	driver-benchmarks/src/main/com/mongodb/benchmark/benchmarks/AbstractMongoBenchmark.java
#	driver-benchmarks/src/main/com/mongodb/benchmark/benchmarks/AbstractWriteBenchmark.java
@vbabanin vbabanin requested a review from rozza March 31, 2025 23:40
throws Exception {
runBenchmark(new RunCommandBenchmark<>(DOCUMENT_CODEC)
.applyMongoClientSettings(MONGO_CLIENT_SETTINGS));
runBenchmark(new FindOneBenchmark<Document>("single_and_multi_document/tweet.json",
Copy link
Member

@rozza rozza Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only observation is that many other file paths are prefixed with "./"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to ""./" for consistency. Thanks!

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - do you have a link to and example of it running on evergreen?

@vbabanin
Copy link
Member Author

vbabanin commented Apr 2, 2025

Yes, there are performance results for Netty execution here: Link

And for the default transport settings: Link

UPD: Link

@vbabanin vbabanin requested a review from rozza April 2, 2025 17:29
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vbabanin - LGTM! :)

@vbabanin vbabanin merged commit a3054ba into mongodb:main Apr 2, 2025
54 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants