Skip to content

Commit

Permalink
minor fix to RubyRedis about bulk commands sent without arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
antirez committed May 25, 2009
1 parent 8cca9b8 commit 0b42016
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
5 changes: 5 additions & 0 deletions Changelog
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2009-05-24 Warns if using the default config
2009-05-24 Issue with redis-client used in scripts solved, now to check if the latest argument must come from standard input we do not check that stdin is or not a tty but the command arity
2009-05-23 RubyRedis: now sets are returned as arrays again, and not as Set objects
2009-05-23 SLAVEOF command documented
2009-05-23 SLAVEOF command implemented for replication remote control
2009-05-22 Fix: no connection timeout for the master!
2009-05-22 replication slave timeout when receiving the initial bulk data set to 3600 seconds, now that replication is non-blocking the server must save the db before to start the async replication and this can take a lot of time with huge datasets
2009-05-22 README tutorial now reflects the new proto
Expand Down
3 changes: 1 addition & 2 deletions TODO
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ BEFORE REDIS 1.0.0-rc1
* maxclients support
* Resize the expires and Sets hash tables if needed as well? For Sets the right moment to check for this is probably in SREM
* What happens if the saving child gets killed or segfaults instead of ending normally? Handle this.
* Make sinterstore / unionstore / sdiffstore returning the cardinality of the resulting set.
* check 'server.dirty' everywere
* check 'server.dirty' everywere. Make it proprotional to the number of objects modified.
* Shutdown must kill other background savings before to start saving. Otherwise the DB can get replaced by the child that rename(2) after the parent for some reason. Child should trap the signal and remove the temp file name.
* Objects sharing configuration, add the directive `objectsharingpool <size>`
* Make sure to convert all the fstat() calls to 64bit versions.
Expand Down
2 changes: 1 addition & 1 deletion client-libraries/ruby_2/rubyredis.rb
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def raw_call_command(argv)
bulk = nil
argv[0] = argv[0].to_s.downcase
argv[0] = Aliases[argv[0]] if Aliases[argv[0]]
if BulkCommands[argv[0]]
if BulkCommands[argv[0]] and argv.length > 1
bulk = argv[-1].to_s
argv[-1] = bulk.length
end
Expand Down

0 comments on commit 0b42016

Please sign in to comment.