Skip to content

Commit

Permalink
chore: instrumentation name and version (redis#2012)
Browse files Browse the repository at this point in the history
  • Loading branch information
nelz9999 authored Feb 2, 2022
1 parent e2d145d commit 3ecadf5
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions extra/redisotel/redisotel.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ import (
)

const (
// todo: consider using the full module path "github.com/go-redis/redis/extra/redisotel"
defaultTracerName = "github.com/go-redis/redis"
defaultTracerName = "github.com/go-redis/redis/extra/redisotel"
)

type TracingHook struct {
Expand All @@ -32,8 +31,7 @@ func NewTracingHook(opts ...Option) *TracingHook {

tracer := cfg.tp.Tracer(
defaultTracerName,
// todo: consider adding a version
// trace.WithInstrumentationVersion("semver:8.11.4"),
trace.WithInstrumentationVersion("semver:"+redis.Version()),
)
return &TracingHook{tracer: tracer}
}
Expand Down

0 comments on commit 3ecadf5

Please sign in to comment.