Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds autosave and diff undo/redo #43

Closed
wants to merge 4 commits into from
Closed

Adds autosave and diff undo/redo #43

wants to merge 4 commits into from

Conversation

factorsofx
Copy link

I forked from the undo/redo via diffs branch and added autosaving as well.

@PJB3005
Copy link
Contributor

PJB3005 commented Jul 6, 2017

Why would you merge the two. These are completely distinct features and there's no reason to merge them into one PR.

All you're doing is ruining atomicity.

@factorsofx
Copy link
Author

Good point. I forked from the undo/redo branch and didn't really intend at first to make a pull request back to the original repository. I'll make another PR that only has the autosave.

@factorsofx factorsofx closed this Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants