"MDL13233, fix unclosed li elements, and remove extra <html> tags, se…

…e tracker"
moodlechick · May 1, 2008 · b8b3d87 · b8b3d87
1 parent fb84ec4
commit b8b3d87
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/help.php b/help.php
@@ -175,7 +175,9 @@ function get_emoticons_html(){
         foreach ($items as $item) {
             $item = explode('{:}', $item);
             $emoticons[$item[0]] = $item[1];
-            $output .= '<li><a href="###" onclick="inserttext(\''.$item[0].'\')"><img src="'.$CFG->pixpath.'/s/'.$item[1].'.gif" alt="'.$item[0].'" /></a>'.' <code>'.$item[0].'</code>';
+            $output .= '<li><a href="javascript:inserttext(\''.$item[0].'\')"><img src="'.
+                $CFG->pixpath.'/s/'.$item[1].'.gif" alt="'.$item[0].'" /></a>'.' <code>'.$item[0].
+                '</code></li>';
         }
 
     }

diff --git a/lang/en_utf8/help/emoticons.html b/lang/en_utf8/help/emoticons.html
@@ -1,5 +1,4 @@
-<html><head>
-<meta http-equiv="content-type" content="text/html; charset=UTF-8"></head><body><h1>Using Smilies (emoticons)</h1>
+<h1>Using Smilies (emoticons)</h1>
 <div id="emoticons">##emoticons_html##</div>
 <div style="clear: both;"></div>
 
@@ -9,5 +8,3 @@
 <p>To insert these icons in your text: just click the icon above, or type the associated text code directly in your text.</p>
 
 <p>Note that the codes themselves are like little pictures - just turn your head to the left when looking at them</p>
-
-</body></html>