Skip to content

Commit

Permalink
Increase length of City field MDL-19629 - Taumata­whakatangihanga­koa…
Browse files Browse the repository at this point in the history
…uau­o­tamatea­turi­pukakapiki­maunga­horo­nuku­pokai­whenua­kitanatahu doesn't actually fit in 100 chars - we need 105 - increasing further to 120
  • Loading branch information
danmarsden committed Jul 8, 2010
1 parent 07b21d0 commit c5c0d2f
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion lib/db/install.xml
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@
<FIELD NAME="institution" TYPE="char" LENGTH="40" NOTNULL="true" SEQUENCE="false" PREVIOUS="phone2" NEXT="department"/>
<FIELD NAME="department" TYPE="char" LENGTH="30" NOTNULL="true" SEQUENCE="false" PREVIOUS="institution" NEXT="address"/>
<FIELD NAME="address" TYPE="char" LENGTH="70" NOTNULL="true" SEQUENCE="false" PREVIOUS="department" NEXT="city"/>
<FIELD NAME="city" TYPE="char" LENGTH="100" NOTNULL="true" SEQUENCE="false" PREVIOUS="address" NEXT="country"/>
<FIELD NAME="city" TYPE="char" LENGTH="120" NOTNULL="true" SEQUENCE="false" PREVIOUS="address" NEXT="country"/>
<FIELD NAME="country" TYPE="char" LENGTH="2" NOTNULL="true" SEQUENCE="false" PREVIOUS="city" NEXT="lang"/>
<FIELD NAME="lang" TYPE="char" LENGTH="30" NOTNULL="true" DEFAULT="en" SEQUENCE="false" PREVIOUS="country" NEXT="theme"/>
<FIELD NAME="theme" TYPE="char" LENGTH="50" NOTNULL="true" SEQUENCE="false" PREVIOUS="lang" NEXT="timezone"/>
Expand Down
8 changes: 4 additions & 4 deletions lib/db/upgrade.php
Original file line number Diff line number Diff line change
Expand Up @@ -4687,7 +4687,7 @@ function xmldb_main_upgrade($oldversion) {
upgrade_main_savepoint(true, 2010070604);
}

if ($oldversion < 2010070701) {
if ($oldversion < 2010070801) {
/// Before changing the field, drop dependent indexes
/// Define index shortname (not unique) to be dropped form course_request
$table = new xmldb_table('user');
Expand All @@ -4696,8 +4696,8 @@ function xmldb_main_upgrade($oldversion) {
if ($dbman->index_exists($table, $index)) {
$dbman->drop_index($table, $index);
}
/// Changing precision of field city on table user to (100)
$field = new xmldb_field('city', XMLDB_TYPE_CHAR, '100', null, XMLDB_NOTNULL, null, null, 'address');
/// Changing precision of field city on table user to (120)
$field = new xmldb_field('city', XMLDB_TYPE_CHAR, '120', null, XMLDB_NOTNULL, null, null, 'address');

/// Launch change of precision for field city
$dbman->change_field_precision($table, $field);
Expand All @@ -4707,7 +4707,7 @@ function xmldb_main_upgrade($oldversion) {
$dbman->add_index($table, $index);
}
/// Main savepoint reached
upgrade_main_savepoint(true, 2010070701);
upgrade_main_savepoint(true, 2010070801);
}

return true;
Expand Down
2 changes: 1 addition & 1 deletion lib/moodlelib.php
Original file line number Diff line number Diff line change
Expand Up @@ -3391,7 +3391,7 @@ function truncate_userinfo($info) {
'institution' => 40,
'department' => 30,
'address' => 70,
'city' => 100,
'city' => 120,
'country' => 2,
'url' => 255,
);
Expand Down
2 changes: 1 addition & 1 deletion login/signup_form.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function definition() {
$mform->setType('lastname', PARAM_TEXT);
$mform->addRule('lastname', get_string('missinglastname'), 'required', null, 'server');

$mform->addElement('text', 'city', get_string('city'), 'maxlength="100" size="20"');
$mform->addElement('text', 'city', get_string('city'), 'maxlength="120" size="20"');
$mform->setType('city', PARAM_TEXT);
$mform->addRule('city', get_string('missingcity'), 'required', null, 'server');

Expand Down
2 changes: 1 addition & 1 deletion user/editlib.php
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ function useredit_shared_definition(&$mform, $editoroptions = null) {
$mform->setDefault('screenreader', 0);
$mform->addHelpButton('screenreader', 'screenreaderuse');

$mform->addElement('text', 'city', get_string('city'), 'maxlength="100" size="21"');
$mform->addElement('text', 'city', get_string('city'), 'maxlength="120" size="21"');
$mform->setType('city', PARAM_MULTILANG);
$mform->addRule('city', $strrequired, 'required', null, 'client');

Expand Down
2 changes: 1 addition & 1 deletion version.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// This is compared against the values stored in the database to determine
// whether upgrades should be performed (see lib/db/*.php)

$version = 2010070800; // YYYYMMDD = date of the last version bump
$version = 2010070801; // YYYYMMDD = date of the last version bump
// XX = daily increments

$release = '2.0 Preview 4+ (Build: 20100708)'; // Human-friendly version name
Expand Down

0 comments on commit c5c0d2f

Please sign in to comment.