datalib MDL-14679 Fixed regression in get_logs_userday function, miss…

…ing argument
moosetrout · Mar 18, 2010 · 66a0612 · 66a0612
1 parent 2d10c08
commit 66a0612
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/lib/datalib.php b/lib/datalib.php
@@ -2263,21 +2263,20 @@ function get_logs_usercourse($userid, $courseid, $coursestart) {
 function get_logs_userday($userid, $courseid, $daystart) {
     global $DB;
 
-    $params = array();
+    $params = array($daystart, $userid, $daystart);
 
     $courseselect = '';
     if ($courseid) {
-        $courseselect = "AND course = :courseid";
-        $params['courseid'] = $courseid;
+        $courseselect = "AND course = ?";
+        $params[] = $courseid;
     }
-    $params['userid'] = $userid;
-    $params['daystart'] = $daystart;
+    $params[] = $daystart;
 
-    return $DB->get_records_sql("SELECT FLOOR((time - :daystart)/". HOURSECS .") AS hour, COUNT(*) AS num
+    return $DB->get_records_sql("SELECT FLOOR((time - ?)/". HOURSECS .") AS hour, COUNT(*) AS num
                                    FROM {log}
-                                  WHERE userid = :userid
-                                        AND time > :daystart $courseselect
-                               GROUP BY FLOOR((time - :daystart)/". HOURSECS .") ");
+                                  WHERE userid = ?
+                                        AND time > ? $courseselect
+                               GROUP BY FLOOR((time - ?)/". HOURSECS .") ", $params);
 }
 
 /**