Merge pull request github#33 from github/no-datetime

Ignore malformed dates

test/relative-time.js

@@ -42,6 +42,31 @@ test('switches to dates after 30 days', function() {
   ok(time.textContent.match(/on \w\w\w \d{1,2}/));
 });
 
+test('ignores malformed dates', function() {
+  var time = document.createElement('time', 'relative-time');
+  time.textContent = 'Jun 30';
+  time.setAttribute('datetime', 'bogus');
+  equal(time.textContent, 'Jun 30');
+});
+
+test('ignores blank dates', function() {
+  var time = document.createElement('time', 'relative-time');
+  time.textContent = 'Jun 30';
+  time.setAttribute('datetime', '');
+  equal(time.textContent, 'Jun 30');
+});
+
+test('ignores removed dates', function() {
+  var time = document.createElement('time', 'relative-time');
+  var now = new Date().toISOString();
+
+  time.setAttribute('datetime', now);
+  equal(time.textContent, 'just now');
+
+  time.removeAttribute('datetime');
+  equal(time.textContent, 'just now');
+});
+
 test('sets relative contents when parsed element is upgraded', function() {
   var now = new Date().toISOString();
   var root = document.createElement('div');

time-elements.js

@@ -266,7 +266,8 @@
   // Returns nothing.
   ExtendedTimePrototype.attributeChangedCallback = function(attrName, oldValue, newValue) {
     if (attrName === 'datetime') {
-      this._date = new Date(Date.parse(newValue));
+      var millis = Date.parse(newValue);
+      this._date = isNaN(millis) ? null : new Date(millis);
     }
 
     var title = this.getFormattedTitle();