openal: Use dummyDriver when no sound driver is found

Updates ebitengine#77
mortdeus · Jun 19, 2019 · 5407e1c · 5407e1c
1 parent 3b9e94d
commit 5407e1c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/driver_openal.go b/driver_openal.go
@@ -128,11 +128,13 @@ func alFormat(channelNum, bitDepthInBytes int) C.ALenum {
 
 const numBufs = 2
 
-func newDriver(sampleRate, channelNum, bitDepthInBytes, bufferSizeInBytes int) (*driver, error) {
+func newDriver(sampleRate, channelNum, bitDepthInBytes, bufferSizeInBytes int) (tryWriteCloser, error) {
 	name := C.alGetString(C.ALC_DEFAULT_DEVICE_SPECIFIER)
 	d := alDevice(C._alcOpenDevice((*C.ALCchar)(name)))
 	if d == 0 {
-		return nil, fmt.Errorf("oto: alcOpenDevice must not return null")
+		// No device was found. Return the dummy device (#77).
+		// TODO: Retry to open the device when possible.
+		return newDummyDriver(sampleRate, channelNum, bitDepthInBytes), nil
 	}
 	c := alContext(C._alcCreateContext(C.uintptr_t(d), nil))
 	if c == 0 {

diff --git a/driver_windows.go b/driver_windows.go
@@ -72,7 +72,7 @@ func newDriver(sampleRate, channelNum, bitDepthInBytes, bufferSizeInBytes int) (
 	w, err := waveOutOpen(f)
 	const elementNotFound = 1168
 	if e, ok := err.(*winmmError); ok && e.errno == elementNotFound {
-		// No device was found. Return the dummy device.
+		// No device was found. Return the dummy device (#77).
 		// TODO: Retry to open the device when possible.
 		return newDummyDriver(sampleRate, channelNum, bitDepthInBytes), nil
 	}