Drop explicit zeroing at instantiation of Atomic* objects

integration-tests/src/test/java/org/springframework/scheduling/annotation/ScheduledAndTransactionalAnnotationIntegrationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -182,7 +182,7 @@ static MyAspect myAspect() {
 	@Aspect
 	public static class MyAspect {
 
-		private final AtomicInteger count = new AtomicInteger(0);
+		private final AtomicInteger count = new AtomicInteger();
 
 		@org.aspectj.lang.annotation.Before("execution(* scheduled())")
 		public void checkTransaction() {
@@ -200,7 +200,7 @@ public interface MyRepository {
 	@Repository
 	static class MyRepositoryImpl implements MyRepository {
 
-		private final AtomicInteger count = new AtomicInteger(0);
+		private final AtomicInteger count = new AtomicInteger();
 
 		@Transactional
 		@Scheduled(fixedDelay = 5)
@@ -226,7 +226,7 @@ public interface MyRepositoryWithScheduledMethod {
 	@Repository
 	static class MyRepositoryWithScheduledMethodImpl implements MyRepositoryWithScheduledMethod {
 
-		private final AtomicInteger count = new AtomicInteger(0);
+		private final AtomicInteger count = new AtomicInteger();
 
 		@Autowired(required = false)
 		private MyAspect myAspect;

spring-aop/src/main/java/org/springframework/aop/support/ControlFlowPointcut.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -45,7 +45,7 @@ public class ControlFlowPointcut implements Pointcut, ClassFilter, MethodMatcher
 	@Nullable
 	private final String methodName;
 
-	private final AtomicInteger evaluations = new AtomicInteger(0);
+	private final AtomicInteger evaluations = new AtomicInteger();
 
 
 	/**

spring-beans/src/test/java/org/springframework/beans/factory/FactoryBeanTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -286,7 +286,7 @@ public Object postProcessAfterInitialization(Object bean, String beanName) {
 			}
 			AtomicInteger c = count.get(beanName);
 			if (c == null) {
-				c = new AtomicInteger(0);
+				c = new AtomicInteger();
 				count.put(beanName, c);
 			}
 			c.incrementAndGet();

spring-context/src/test/java/org/springframework/cache/interceptor/CacheProxyFactoryBeanTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -113,7 +113,7 @@ default String greet(String name) {
 
 	static class SimpleGreeter implements Greeter {
 
-		private final AtomicBoolean cacheMiss = new AtomicBoolean(false);
+		private final AtomicBoolean cacheMiss = new AtomicBoolean();
 
 		@Override
 		public boolean isCacheMiss() {

spring-core/src/main/java/org/springframework/util/ConcurrentReferenceHashMap.java

@@ -474,7 +474,7 @@ protected final class Segment extends ReentrantLock {
 		 * The total number of references contained in this segment. This includes chained
 		 * references and references that have been garbage collected but not purged.
 		 */
-		private final AtomicInteger count = new AtomicInteger(0);
+		private final AtomicInteger count = new AtomicInteger();
 
 		/**
 		 * The threshold when resizing of the references should occur. When {@code count}

spring-core/src/main/java/org/springframework/util/CustomizableThreadCreator.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -44,7 +44,7 @@ public class CustomizableThreadCreator implements Serializable {
 	@Nullable
 	private ThreadGroup threadGroup;
 
-	private final AtomicInteger threadCount = new AtomicInteger(0);
+	private final AtomicInteger threadCount = new AtomicInteger();
 
 
 	/**

spring-core/src/main/java/org/springframework/util/SimpleIdGenerator.java

@@ -28,7 +28,7 @@
  */
 public class SimpleIdGenerator implements IdGenerator {
 
-	private final AtomicLong leastSigBits = new AtomicLong(0);
+	private final AtomicLong leastSigBits = new AtomicLong();
 
 
 	@Override

spring-expression/src/main/java/org/springframework/expression/spel/standard/SpelExpression.java

@@ -71,11 +71,11 @@ public class SpelExpression implements Expression {
 
 	// Count of many times as the expression been interpreted - can trigger compilation
 	// when certain limit reached
-	private final AtomicInteger interpretedCount = new AtomicInteger(0);
+	private final AtomicInteger interpretedCount = new AtomicInteger();
 
 	// The number of times compilation was attempted and failed - enables us to eventually
 	// give up trying to compile it when it just doesn't seem to be possible.
-	private final AtomicInteger failedAttempts = new AtomicInteger(0);
+	private final AtomicInteger failedAttempts = new AtomicInteger();
 
 
 	/**

spring-messaging/src/main/java/org/springframework/messaging/simp/broker/AbstractBrokerMessageHandler.java

@@ -63,7 +63,7 @@ public abstract class AbstractBrokerMessageHandler
 	@Nullable
 	private ApplicationEventPublisher eventPublisher;
 
-	private AtomicBoolean brokerAvailable = new AtomicBoolean(false);
+	private AtomicBoolean brokerAvailable = new AtomicBoolean();
 
 	private final BrokerAvailabilityEvent availableEvent = new BrokerAvailabilityEvent(true, this);
 

spring-messaging/src/main/java/org/springframework/messaging/simp/broker/OrderedMessageChannelDecorator.java

@@ -52,7 +52,7 @@ public class OrderedMessageChannelDecorator implements MessageChannel {
 
 	private final Queue<Message<?>> messages = new ConcurrentLinkedQueue<>();
 
-	private final AtomicBoolean sendInProgress = new AtomicBoolean(false);
+	private final AtomicBoolean sendInProgress = new AtomicBoolean();
 
 
 	public OrderedMessageChannelDecorator(MessageChannel channel, Log logger) {

spring-messaging/src/test/java/org/springframework/messaging/rsocket/DefaultRSocketRequesterTests.java

@@ -185,7 +185,7 @@ public void retrieveMono() {
 
 	@Test
 	public void retrieveMonoVoid() {
-		AtomicBoolean consumed = new AtomicBoolean(false);
+		AtomicBoolean consumed = new AtomicBoolean();
 		Mono<Payload> mono = Mono.delay(MILLIS_10).thenReturn(toPayload("bodyA")).doOnSuccess(p -> consumed.set(true));
 		this.rsocket.setPayloadMonoToReturn(mono);
 		this.requester.route("").data("").retrieveMono(Void.class).block(Duration.ofSeconds(5));
@@ -215,7 +215,7 @@ public void retrieveFlux() {
 
 	@Test
 	public void retrieveFluxVoid() {
-		AtomicBoolean consumed = new AtomicBoolean(false);
+		AtomicBoolean consumed = new AtomicBoolean();
 		Flux<Payload> flux = Flux.just("bodyA", "bodyB")
 				.delayElements(MILLIS_10).map(this::toPayload).doOnComplete(() -> consumed.set(true));
 		this.rsocket.setPayloadFluxToReturn(flux);

spring-messaging/src/test/java/org/springframework/messaging/rsocket/RSocketClientToServerIntegrationTests.java

@@ -317,9 +317,9 @@ private static class CountingInterceptor implements RSocket, RSocketInterceptor
 
 		private RSocket delegate;
 
-		private final AtomicInteger fireAndForgetCount = new AtomicInteger(0);
+		private final AtomicInteger fireAndForgetCount = new AtomicInteger();
 
-		private final AtomicInteger metadataPushCount = new AtomicInteger(0);
+		private final AtomicInteger metadataPushCount = new AtomicInteger();
 
 
 		public int getFireAndForgetCount() {

spring-messaging/src/test/java/org/springframework/messaging/support/ChannelInterceptorTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -86,8 +86,8 @@ public void preSendInterceptorReturningNull() {
 
 	@Test
 	public void postSendInterceptorMessageWasSent() {
-		final AtomicBoolean preSendInvoked = new AtomicBoolean(false);
-		final AtomicBoolean completionInvoked = new AtomicBoolean(false);
+		final AtomicBoolean preSendInvoked = new AtomicBoolean();
+		final AtomicBoolean completionInvoked = new AtomicBoolean();
 		this.channel.addInterceptor(new ChannelInterceptor() {
 			@Override
 			public void postSend(Message<?> message, MessageChannel channel, boolean sent) {
@@ -119,8 +119,8 @@ protected boolean sendInternal(Message<?> message, long timeout) {
 				return false;
 			}
 		};
-		final AtomicBoolean preSendInvoked = new AtomicBoolean(false);
-		final AtomicBoolean completionInvoked = new AtomicBoolean(false);
+		final AtomicBoolean preSendInvoked = new AtomicBoolean();
+		final AtomicBoolean completionInvoked = new AtomicBoolean();
 		testChannel.addInterceptor(new ChannelInterceptor() {
 			@Override
 			public void postSend(Message<?> message, MessageChannel channel, boolean sent) {

spring-orm/src/test/java/org/springframework/orm/jpa/support/OpenEntityManagerInViewTests.java

@@ -351,15 +351,15 @@ public void testOpenEntityManagerInViewFilterAsyncScenario() throws Exception {
 		final OpenEntityManagerInViewFilter filter2 = new OpenEntityManagerInViewFilter();
 		filter2.init(filterConfig2);
 
-		final AtomicInteger count = new AtomicInteger(0);
+		final AtomicInteger count = new AtomicInteger();
 
 		final FilterChain filterChain = (servletRequest, servletResponse) -> {
 			assertThat(TransactionSynchronizationManager.hasResource(factory)).isTrue();
 			servletRequest.setAttribute("invoked", Boolean.TRUE);
 			count.incrementAndGet();
 		};
 
-		final AtomicInteger count2 = new AtomicInteger(0);
+		final AtomicInteger count2 = new AtomicInteger();
 
 		final FilterChain filterChain2 = (servletRequest, servletResponse) -> {
 			assertThat(TransactionSynchronizationManager.hasResource(factory2)).isTrue();

spring-test/src/main/java/org/springframework/test/context/transaction/TransactionContext.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -55,7 +55,7 @@ class TransactionContext {
 	@Nullable
 	private TransactionStatus transactionStatus;
 
-	private final AtomicInteger transactionsStarted = new AtomicInteger(0);
+	private final AtomicInteger transactionsStarted = new AtomicInteger();
 
 
 	TransactionContext(TestContext testContext, PlatformTransactionManager transactionManager,

spring-test/src/test/java/org/springframework/mock/web/MockHttpSessionTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -177,7 +177,7 @@ void bindingListenerBindListenerOverwrite() {
 	private static class CountingHttpSessionBindingListener
 			implements HttpSessionBindingListener {
 
-		private final AtomicInteger counter = new AtomicInteger(0);
+		private final AtomicInteger counter = new AtomicInteger();
 
 		@Override
 		public void valueBound(HttpSessionBindingEvent event) {

spring-test/src/test/java/org/springframework/test/context/cache/ClassLevelDirtiesContextTestNGTests.java

@@ -52,8 +52,8 @@
  */
 class ClassLevelDirtiesContextTestNGTests {
 
-	private static final AtomicInteger cacheHits = new AtomicInteger(0);
-	private static final AtomicInteger cacheMisses = new AtomicInteger(0);
+	private static final AtomicInteger cacheHits = new AtomicInteger();
+	private static final AtomicInteger cacheMisses = new AtomicInteger();
 
 
 	@BeforeAll

spring-test/src/test/java/org/springframework/test/context/cache/ClassLevelDirtiesContextTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -51,8 +51,8 @@
  */
 class ClassLevelDirtiesContextTests {
 
-	private static final AtomicInteger cacheHits = new AtomicInteger(0);
-	private static final AtomicInteger cacheMisses = new AtomicInteger(0);
+	private static final AtomicInteger cacheHits = new AtomicInteger();
+	private static final AtomicInteger cacheMisses = new AtomicInteger();
 
 
 	@BeforeAll

spring-test/src/test/java/org/springframework/test/context/configuration/interfaces/DirtiesContextInterfaceTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -43,8 +43,8 @@
  */
 class DirtiesContextInterfaceTests {
 
-	private static final AtomicInteger cacheHits = new AtomicInteger(0);
-	private static final AtomicInteger cacheMisses = new AtomicInteger(0);
+	private static final AtomicInteger cacheHits = new AtomicInteger();
+	private static final AtomicInteger cacheMisses = new AtomicInteger();
 
 
 	@BeforeAll

spring-test/src/test/java/org/springframework/test/web/servlet/samples/spr/HttpOptionsTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -86,7 +86,7 @@ public MyController myController() {
 	@Controller
 	private static class MyController {
 
-		private AtomicInteger counter = new AtomicInteger(0);
+		private AtomicInteger counter = new AtomicInteger();
 
 
 		@RequestMapping(value = "/myUrl", method = RequestMethod.OPTIONS)

spring-tx/src/main/java/org/springframework/transaction/reactive/AbstractReactiveTransactionManager.java

@@ -431,7 +431,7 @@ public final Mono<Void> commit(ReactiveTransaction transaction) throws Transacti
 	private Mono<Void> processCommit(TransactionSynchronizationManager synchronizationManager,
 			GenericReactiveTransaction status) throws TransactionException {
 
-		AtomicBoolean beforeCompletionInvoked = new AtomicBoolean(false);
+		AtomicBoolean beforeCompletionInvoked = new AtomicBoolean();
 
 		Mono<Object> commit = prepareForCommit(synchronizationManager, status)
 				.then(triggerBeforeCommit(synchronizationManager, status))

spring-web/src/main/java/org/springframework/http/client/reactive/ReactorClientHttpResponse.java

@@ -62,7 +62,7 @@ class ReactorClientHttpResponse implements ClientHttpResponse {
 	private final NettyDataBufferFactory bufferFactory;
 
 	// 0 - not subscribed, 1 - subscribed, 2 - cancelled via connector (before subscribe)
-	private final AtomicInteger state = new AtomicInteger(0);
+	private final AtomicInteger state = new AtomicInteger();
 
 	private final String logPrefix;
 

spring-web/src/main/java/org/springframework/http/codec/multipart/SynchronossPartHttpMessageReader.java

@@ -339,7 +339,7 @@ private static class FluxSinkAdapterListener implements NioMultipartParserListen
 
 		private final LimitedPartBodyStreamStorageFactory storageFactory;
 
-		private final AtomicInteger terminated = new AtomicInteger(0);
+		private final AtomicInteger terminated = new AtomicInteger();
 
 		FluxSinkAdapterListener(
 				FluxSink<Part> sink, MultipartContext context, LimitedPartBodyStreamStorageFactory factory) {

spring-web/src/main/java/org/springframework/http/server/ServletServerHttpAsyncRequestControl.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -46,7 +46,7 @@ public class ServletServerHttpAsyncRequestControl implements ServerHttpAsyncRequ
 	@Nullable
 	private AsyncContext asyncContext;
 
-	private AtomicBoolean asyncCompleted = new AtomicBoolean(false);
+	private AtomicBoolean asyncCompleted = new AtomicBoolean();
 
 
 	/**

spring-web/src/main/java/org/springframework/http/server/reactive/ReactorServerHttpRequest.java

@@ -48,7 +48,7 @@
  */
 class ReactorServerHttpRequest extends AbstractServerHttpRequest {
 
-	private static final AtomicLong logPrefixIndex = new AtomicLong(0);
+	private static final AtomicLong logPrefixIndex = new AtomicLong();
 
 
 	private final HttpServerRequest request;

spring-web/src/main/java/org/springframework/web/context/request/async/StandardServletAsyncWebRequest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -48,7 +48,7 @@ public class StandardServletAsyncWebRequest extends ServletWebRequest implements
 
 	private AsyncContext asyncContext;
 
-	private AtomicBoolean asyncCompleted = new AtomicBoolean(false);
+	private AtomicBoolean asyncCompleted = new AtomicBoolean();
 
 	private final List<Runnable> timeoutHandlers = new ArrayList<>();
 

spring-web/src/test/java/org/springframework/http/client/reactive/ReactorResourceFactoryTests.java

@@ -61,7 +61,7 @@ void globalResources() throws Exception {
 	@Test
 	void globalResourcesWithConsumer() throws Exception {
 
-		AtomicBoolean invoked = new AtomicBoolean(false);
+		AtomicBoolean invoked = new AtomicBoolean();
 
 		this.resourceFactory.addGlobalResourcesConsumer(httpResources -> invoked.set(true));
 		this.resourceFactory.afterPropertiesSet();