Skip to content

Commit

Permalink
Merge branch 'wd/rebase-conflict-guide'
Browse files Browse the repository at this point in the history
The advice message given when "git rebase" stops for conflicting
changes has been improved.

* wd/rebase-conflict-guide:
  rebase: make resolve message clearer for inexperienced users
  • Loading branch information
gitster committed Aug 11, 2017
2 parents 12deaf6 + 5fdacc1 commit 076eeec
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions git-rebase.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,10 @@ LF='
'
ok_to_skip_pre_rebase=
resolvemsg="
$(gettext 'When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".')
$(gettext 'Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".')
"
unset onto
unset restrict_revision
Expand Down
4 changes: 2 additions & 2 deletions t/t5520-pull.sh
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ test_expect_success '--rebase with conflicts shows advice' '
test_tick &&
git commit -m "Create conflict" seq.txt &&
test_must_fail git pull --rebase . seq 2>err >out &&
test_i18ngrep "When you have resolved this problem" out
test_i18ngrep "Resolve all conflicts manually" out
'

test_expect_success 'failed --rebase shows advice' '
Expand All @@ -319,7 +319,7 @@ test_expect_success 'failed --rebase shows advice' '
git checkout -f -b fails-to-rebase HEAD^ &&
test_commit v2-without-cr file "2" file2-lf &&
test_must_fail git pull --rebase . diverging 2>err >out &&
test_i18ngrep "When you have resolved this problem" out
test_i18ngrep "Resolve all conflicts manually" out
'

test_expect_success '--rebase fails with multiple branches' '
Expand Down

0 comments on commit 076eeec

Please sign in to comment.