Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove boost from motion_planning_rviz_plugin #2308

Conversation

todoubaba
Copy link
Contributor

Description

rviz_rendering::MovableText can only display non-mono font family currently, it is pointless to format the values with width (and the length of some label is greater than 10).

ss << boost::format("%-10s %-4.2f") % value.first % value.second << '\n';

so we can remove boost from dependencies.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a minor nitpick that is supposed to make the code easier to read

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (a2f0183) 50.71% compared to head (e773c84) 50.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2308      +/-   ##
==========================================
- Coverage   50.71%   50.68%   -0.02%     
==========================================
  Files         386      386              
  Lines       31914    31914              
==========================================
- Hits        16182    16173       -9     
- Misses      15732    15741       +9     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henningkayser henningkayser merged commit 05f3501 into moveit:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants