Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade-db action to run script #92

Merged
merged 3 commits into from
Jun 9, 2016

Conversation

bhearsum
Copy link
Contributor

@bhearsum bhearsum commented Jun 9, 2016

This is primarily for CloudOps' benefit - @mostlygeek requested a wrapper that would make trivial for them to do db upgrades.

I tested it locally by going back to db version 12, tweaking docker-compose to run this command instead of admin-dev, and then "docker-compose up" -- it upgraded the db to version 13 as expected.

How does this look to you, @rail?

@@ -6,6 +6,12 @@ elif [ $1 == "admin" ]; then
exec uwsgi --ini /app/uwsgi/admin.ini --python-autoreload 1
elif [ $1 == "admin-dev" ]; then
exec uwsgi --ini /app/uwsgi/admin.dev.ini --ini /app/uwsgi/admin.ini --python-autoreload 1
elif [ $1 == "upgrade-db" ]; then
if [ -z ${DBURI} ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the variable should be quoted, I trust our old scripts :) http://hg.mozilla.org/build/tools/file/tip/release/updates/verify.sh#l148

@bhearsum bhearsum merged commit 09a1d97 into mozilla-releng:master Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants