Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bug 1257146 - Product build types pure implementation #3250

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Mar 24, 2016

No description provided.

@peterbe peterbe force-pushed the bug-1257146-product-build-types-pure-implementation branch from 4d1513d to 63f4b7e Compare March 24, 2016 12:00
@@ -26,6 +26,7 @@
import socorro.external.postgresql.gccrashes
import socorro.external.postgresql.crontabber_state
import socorro.external.postgresql.adi
import socorro.external.postgresql.product_build_types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe at some point we'll want to import the whole socorro.external.postgresql, don't you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would only be possible if socorro/external/postgresql/__init__.py imports all those modules.

@adngdb
Copy link
Contributor

adngdb commented Mar 24, 2016

r+

@adngdb adngdb merged commit e95020b into mozilla-services:master Mar 24, 2016
@peterbe peterbe deleted the bug-1257146-product-build-types-pure-implementation branch March 28, 2016 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants