Pass W&B suffix to publish_group_logs (offline experiments) (#818)

* Pass W&B suffix to publish_group_logs (offline experiments) * Nit --------- Co-authored-by: Evgeny Pavlov <[email protected]>
mozilla · Aug 30, 2024 · f7247a6 · f7247a6
1 parent 676cb4f
commit f7247a6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/tracking/translations_parser/cli/taskcluster_group.py b/tracking/translations_parser/cli/taskcluster_group.py
@@ -213,6 +213,7 @@ def publish_task_group(group_id: str, override: bool = False) -> None:
     experiment = config["experiment"]
     project_name = f'{experiment["src"]}-{experiment["trg"]}'
     group_name = f'{experiment["name"]}_{group_id}'
+    suffix = suffix_from_group(group_id)
 
     grouped_tasks = list_completed_tasks(group_id)
     training_tasks = list_training_tasks(group_id, grouped_tasks)
@@ -260,7 +261,7 @@ def publish_task_group(group_id: str, override: bool = False) -> None:
         publish_task(
             project=project_name,
             group=group_name,
-            suffix=suffix_from_group(group_id),
+            suffix=suffix,
             name=training_task["name"],
             task=training_task,
             metrics=metrics,
@@ -270,6 +271,7 @@ def publish_task_group(group_id: str, override: bool = False) -> None:
     publish_group_logs_from_tasks(
         project=project_name,
         group=group_name,
+        suffix=suffix,
         metrics_tasks=metrics_tasks,
         config=config,
     )

diff --git a/tracking/translations_parser/utils.py b/tracking/translations_parser/utils.py
@@ -204,7 +204,7 @@ def publish_group_logs_from_tasks(
     *,
     project: str,
     group: str,
-    suffix: str | None = None,
+    suffix: str = "",
     metrics_tasks: dict[str, dict] = {},
     config: dict = {},
 ):