Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback target renaming #960

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Rollback target renaming #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b8ca18
Rename kind
eu9ene Nov 25, 2024
6c3bd2e
Roll back target renaming
eu9ene Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions taskcluster/kinds/all-pipeline/kind.yml → taskcluster/kinds/all/kind.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ kind-dependencies:
- analyze-mono

tasks:
all-pipeline:
all:
description: Dummy task that ensures all parts of training pipeline will run
attributes:
stage: all-pipeline
stage: all
src_locale: "{src_locale}"
trg_locale: "{trg_locale}"

Expand Down
2 changes: 1 addition & 1 deletion taskcluster/test/test_default_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@

def test_last_task_is_targeted(target_task_set: TaskGraph):
"""Ensure that the last task in the pipeline is targeted by default"""
assert any([task == "all-pipeline-ru-en-1" for task in target_task_set.tasks])
assert any([task == "all-ru-en-1" for task in target_task_set.tasks])


def test_cached_tasks_optimized_away(optimized_task_graph: TaskGraph):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_preflight_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def test_task_group():
assert "Training config" not in output
assert "Visualization" not in output

assert "all-pipeline-en-ru-1" in output
assert "all-en-ru-1" in output
assert not opened_url


Expand Down