Do not output empty alignments #963
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtatum
reviewed
Dec 18, 2024
| @@ -104,13 +104,16 @@ def build_dataset_tsv( | |||
| empty_alignments = [] | |||
|
|
|||
| for src_line, trg_line, aln_line in zip(src_lines, trg_lines, aln_lines): | |||
| if not aln_line: | |||
| if aln_line.strip(): | |||
There was a problem hiding this comment.
I'm not understanding this patch from the description of the changes compared to the code change. The only real behavior change I'm seeing is that the alignment line is stripped first to see if it's blank. The rest is just code refactoring.
It's also still outputting the a sample of the alignments.
There was a problem hiding this comment.
It did the trick. Marian used to complain without outputting the sample, so I assume there are some newlines or something else that made it not empty: https://firefox-ci-tc.services.mozilla.com/tasks/JQuHsJS2R6-RuPR-O9XMXQ/runs/0/logs/public/logs/live.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It pollutes the log and I think it also causes issues with the W&B parser