MDL-56646 assign: Fix negative grades in restore

mpetrowi · Aug 29, 2017 · 465b75e · 465b75e
1 parent 7323c47
commit 465b75e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/mod/assign/backup/moodle2/restore_assign_stepslib.php b/mod/assign/backup/moodle2/restore_assign_stepslib.php
@@ -240,7 +240,10 @@ protected function process_assign_grade($data) {
             $flags->userid = $this->get_mappingid('user', $data->userid);
             $DB->insert_record('assign_user_flags', $flags);
         }
-
+        // Fix null grades that were rescaled.
+        if ($data->grade < 0 && $data->grade != ASSIGN_GRADE_NOT_SET) {
+            $data->grade = ASSIGN_GRADE_NOT_SET;
+        }
         $newitemid = $DB->insert_record('assign_grades', $data);
 
         // Note - the old contextid is required in order to be able to restore files stored in

diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php
@@ -8612,7 +8612,7 @@ protected function view_fix_rescaled_null_grades() {
 
             // Fix the grades.
             $this->fix_null_grades();
-            set_config('has_rescaled_null_grades_' . $instance->id, 0, 'assign');
+            unset_config('has_rescaled_null_grades_' . $instance->id, 'assign');
 
             // Display the notice.
             $o .= $this->get_renderer()->notification(get_string('fixrescalednullgradesdone', 'assign'), 'notifysuccess');