Skip to content

Commit

Permalink
MDL-50666 behat: Make feature names unique
Browse files Browse the repository at this point in the history
* We need to have unique feature names for our Behat tests.
* I also removed the custom Behat tag @role_visibility as we only allow
Behat tags with the component name in Frankenstyle format.
  • Loading branch information
junpataleta committed Dec 20, 2017
1 parent a8dffa2 commit ccb8edb
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions badges/tests/behat/role_visibility.feature
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@core @core_badges @role_visibility
Feature: Test role visibility
@core @core_badges
Feature: Test role visibility for the badge administration page
In order to control access
As an admin
I need to control which roles can see each other
Expand Down Expand Up @@ -48,4 +48,4 @@ Feature: Test role visibility
And I set the following fields to these values:
| Add badge criteria | Manual issue by role |
Then I should see "Teacher"
And I should not see "Manager"
And I should not see "Manager"
6 changes: 3 additions & 3 deletions enrol/tests/behat/role_visibility.feature
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@core @core_enrol @role_visibility
Feature: Test role visibility
@core @core_enrol
Feature: Test role visibility for the participants page
In order to control access
As an admin
I need to control which roles can see each other
Expand Down Expand Up @@ -35,4 +35,4 @@ Feature: Test role visibility
Then "Learner 1" row "Roles" column of "participants" table should contain "Student"
And "Teacher 1" row "Roles" column of "participants" table should contain "Teacher"
And "Manager 1" row "Roles" column of "participants" table should not contain "Manager"
And "Manager 1" row "Roles" column of "participants" table should contain "No roles"
And "Manager 1" row "Roles" column of "participants" table should contain "No roles"
4 changes: 2 additions & 2 deletions group/tests/behat/role_visibility.feature
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@core @core_group @role_visibility
Feature: Test role visibility
@core @core_group
Feature: Test role visibility for the groups management page
In order to control access
As an admin
I need to control which roles can see each other
Expand Down

0 comments on commit ccb8edb

Please sign in to comment.