Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etc/restore-osc-bindings.conf: add previously unbound actions #15807

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

na-na-hi
Copy link
Contributor

@na-na-hi na-na-hi commented Feb 5, 2025

Changed in b0364f8.

@guidocella
Copy link
Contributor

This was unbound in mpv 0.39.

Copy link

github-actions bot commented Feb 5, 2025

Download the artifacts for this pull request:

Windows
macOS

This makes sure that newly added actions do nothing, like before.
@na-na-hi na-na-hi force-pushed the osc-title-mid-click branch from ac27936 to b2f8b31 Compare February 5, 2025 16:51
@na-na-hi na-na-hi changed the title etc/restore-osc-bindings.conf: update for title middle click etc/restore-osc-bindings.conf: add previously unbound actions Feb 5, 2025
@na-na-hi
Copy link
Contributor Author

na-na-hi commented Feb 5, 2025

I see. Changed to make the newly added actions do nothing to replicate the previous behavior.

@kasper93
Copy link
Contributor

kasper93 commented Feb 5, 2025

Is this really important to do nothing in those cases?

@na-na-hi
Copy link
Contributor Author

na-na-hi commented Feb 5, 2025

Is this really important to do nothing in those cases?

It would be useful when a future version changes these bindings again. For example, if "right click volume button" is changed to something else in 0.41, then the restore entry would be added to restore to 0.40, which still does something; but there is no info to restore to 0.39 behavior.

@kasper93
Copy link
Contributor

kasper93 commented Feb 5, 2025

Is this really important to do nothing in those cases?

It would be useful when a future version changes these bindings again. For example, if "right click volume button" is changed to something else in 0.41, then the restore entry would be added to restore to 0.40, which still does something; but there is no info to restore to 0.39 behavior.

I don't think we have to support restoring settings to every older mpv version. We don't have LTS releases, so it makes it awkward beyond recent one. But whatever, if you want to maintain this file and keep track of everything, I'm not opposing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants