console.lua: disable cursor autohide while selector is open #15822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an improvement on mpv-player#15145 . If the cursor is automatically hidden, users may not know whether they are clicking on the inside or outside of selectable items, the result after clicking is unclear to them.
|
I'm not sure if this is needed anyway but note that I already implemented a proper background with a horizontal hitbox so you can close by clicking outside of it horizontally, I'm just waiting for #15711 to be merged:
We can then unbind right click like you asked if wanted. |
|
Download the artifacts for this pull request: |
|
this looks pretty nice, similar to uosc, I have just tried the uosc and the cursor cannot be hidden while menu is open. |
|
Yeah I blatantly copied uosc's menu since it looked better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement on #15145 .
If the cursor is automatically hidden, users may not know whether they are clicking on the inside or outside of selectable items, the result after clicking is unclear to them.