Skip to content

Commit

Permalink
doc: update BOLT references part1, including bolt11 test vectors with…
Browse files Browse the repository at this point in the history
… payment_secret.

The signatures on the new examples are sometimes different from what we produce though?
They're valid, however.

And one example has an unneeded feature 5-bit; it's not *wrong*, but
it's not optimal.

Signed-off-by: Rusty Russell <[email protected]>
  • Loading branch information
rustyrussell committed Apr 1, 2022
1 parent 3b53640 commit 7491af5
Show file tree
Hide file tree
Showing 4 changed files with 72 additions and 46 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ CCANDIR := ccan

# Where we keep the BOLT RFCs
BOLTDIR := ../lightning-rfc/
DEFAULT_BOLTVERSION := 498f104fd399488c77f449d05cb21c0b604636a2
DEFAULT_BOLTVERSION := c876dac2b5038f6499154d0a739240b6ff5db70d
# Can be overridden on cmdline.
BOLTVERSION := $(DEFAULT_BOLTVERSION)

Expand Down
4 changes: 2 additions & 2 deletions common/htlc_tx.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ static inline struct amount_sat htlc_timeout_fee(u32 feerate_per_kw,
*
* The fee for an HTLC-timeout transaction:
*...
* - Otherwise, MUST BE calculated to match:
* - Otherwise, MUST be calculated to match:
* 1. Multiply `feerate_per_kw` by 663 (666 if `option_anchor_outputs`
* applies) and divide by 1000 (rounding down).
*/
Expand All @@ -40,7 +40,7 @@ static inline struct amount_sat htlc_success_fee(u32 feerate_per_kw,
*
* The fee for an HTLC-success transaction:
*...
* - MUST BE calculated to match:
* - Otherwise, MUST be calculated to match:
* 1. Multiply `feerate_per_kw` by 703 (706 if `option_anchor_outputs`
* applies) and divide by 1000 (rounding down).
*/
Expand Down
Loading

0 comments on commit 7491af5

Please sign in to comment.