Refactor menu presenter

mridultuteja · Jul 24, 2017 · a0edd31 · a0edd31
1 parent d01dd1c
commit a0edd31
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 155 deletions.
diff --git a/app/models/spina/page.rb b/app/models/spina/page.rb
@@ -90,10 +90,6 @@ def view_template_page_parts(theme)
       theme.page_parts.select { |page_part| page_part[:name].in? view_template_config(theme)[:page_parts] }
     end
 
-    def full_materialized_path
-      File.join(Spina::Engine.routes.url_helpers.root_path, materialized_path)
-    end
-
     private
 
       def rewrite_rule

diff --git a/app/presenters/spina/pages/breadcrumb.rb b/app/presenters/spina/pages/breadcrumb.rb
diff --git a/app/presenters/spina/pages/menu_presenter.rb b/app/presenters/spina/pages/menu_presenter.rb
@@ -1,4 +1,3 @@
-# require 'active_support/core_ext/string'
 require 'active_support/configurable'
 require 'action_view/helpers/tag_helper'
 require 'action_view/helpers/url_helper'
@@ -10,84 +9,54 @@ class MenuPresenter
       include ActionView::Helpers::UrlHelper
       include ActiveSupport::Configurable
 
-      config_accessor :list_tag, :list_class, :li, :list_wrapper, :list_item_tag, :list_item_css, :selected_css, :current_css, :first_css, :last_css, :list_tag_with_child_css, :list_item_with_child_css
+      config_accessor :list_tag, :list_class, :list_item_tag, :list_item_css, :selected_css, :current_css
 
       self.list_tag = :ul
       self.list_class = 'nav'
       self.list_item_tag = :li
       self.list_item_css = nil
-      self.list_wrapper = false
       self.selected_css = 'active'
       self.current_css = 'current'
-      self.first_css = 'first'
-      self.last_css = 'last'
-      self.list_tag_with_child_css = 'dropdown-menu'
-      self.list_item_with_child_css = 'dropdown'
 
       attr_accessor :context, :collection, :current_menu_item
       delegate :output_buffer, :output_buffer=, to: :context
 
-      def initialize(collection, context, current_menu_item=nil)
+      def initialize(collection, context, current_menu_item = nil)
         @collection = collection
         @context = context
         @current_menu_item = current_menu_item
         @selected_menu_items = [@current_menu_item] + @current_menu_item.try(:ancestors)
       end
 
       def to_html
-        render_list_wrapper(collection) if collection.present?
+        render_menu_items(collection) if collection.present?
       end
 
       private
 
-      def render_list_wrapper(menu_items)
-        if menu_items.any?
-          if list_wrapper
-            content_tag(:div) do
-              render_menu_items(menu_items)
+        def render_menu_items(menu_items)
+          content_tag(list_tag, class: list_class) do
+            menu_items.each.inject(ActiveSupport::SafeBuffer.new) do |buffer, item|
+              buffer << render_menu_item(item)
             end
-          else
-            render_menu_items(menu_items)
           end
         end
-      end
 
-      def render_menu_items(menu_items)
-        content_tag(list_tag, class: menu_items_css(menu_items)) do
-          menu_items.each_with_index.inject(ActiveSupport::SafeBuffer.new) do |buffer, (item, index)|
-            buffer << render_menu_item(item, index, menu_items.length)
+        def render_menu_item(menu_item)
+          content_tag(list_item_tag, class: menu_item_css(menu_item[0])) do
+            buffer = ActiveSupport::SafeBuffer.new
+            buffer << link_to(menu_item[0].menu_title, menu_item[0].materialized_path)
+            buffer << render_menu_items(menu_item[1])
+            buffer
           end
         end
-      end
 
-      def render_menu_item(menu_item, index, menu_items_length)
-        content_tag(list_item_tag, class: menu_item_css(menu_item[0], index, menu_items_length, !menu_item[1].empty?)) do
-          buffer = ActiveSupport::SafeBuffer.new
-          buffer << link_to(menu_item[0].menu_title, menu_item[0].full_materialized_path)
-          buffer << render_list_wrapper(menu_item[1])
-          buffer
+        def menu_item_css(menu_item)
+          css = [list_item_css]
+          css << selected_css if (@selected_menu_items.present? && @selected_menu_items.include?(menu_item) )
+          css << current_css if @current_menu_item == menu_item
+          css
         end
-      end
-
-      def menu_items_css(menu_items)
-        css = []
-        css << list_class
-        css << list_tag_with_child_css if !menu_items.first[0].ancestry.nil?
-
-        css.reject(&:blank?).presence
-      end
-
-      def menu_item_css(menu_item, index, menu_items_length, has_child)
-        css = []
-        css << list_item_css
-        css << selected_css if (@selected_menu_items.present? && @selected_menu_items.include?(menu_item) )
-        css << current_css if @current_menu_item == menu_item
-        css << first_css if index == 0
-        css << last_css if index + 1 == menu_items_length
-        css << list_item_with_child_css if has_child
-
-        css.reject(&:blank?).presence
-      end
 
     end
   end