Skip to content

Commit

Permalink
[tune] fix testing for serve-tune test breaking (ray-project#9993)
Browse files Browse the repository at this point in the history
  • Loading branch information
richardliaw authored Aug 8, 2020
1 parent 39088ab commit 328b450
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -302,15 +302,15 @@ matrix:
- TORCH_VERSION=1.5
- PYTHONWARNINGS=ignore
install:
- . ./ci/travis/ci.sh init RAY_CI_PYTHON_AFFECTED,RAY_CI_TUNE_AFFECTED
- . ./ci/travis/ci.sh init RAY_CI_PYTHON_AFFECTED,RAY_CI_TUNE_AFFECTED,RAY_CI_DOC_AFFECTED
before_script:
- . ./ci/travis/ci.sh build
script:
- ./ci/keep_alive bazel test --config=ci --build_tests_only --test_tag_filters=-tf,-pytorch,-py37 doc/...
- ./ci/keep_alive bazel test --config=ci --build_tests_only --test_tag_filters=tf,-pytorch,-py37 doc/...
- ./ci/keep_alive bazel test --config=ci --build_tests_only --test_tag_filters=-tf,pytorch,-py37 doc/...

# Tune/SGD/Docs: Python >= 3.7 tests and examples.
# Tune/SGD: Python >= 3.7 tests and examples.
- os: linux
env:
- PYTHON=3.7 TUNE_TESTING=1
Expand All @@ -324,7 +324,7 @@ matrix:
- . ./ci/travis/ci.sh build
script:
- ./ci/keep_alive bazel test --config=ci --build_tests_only --test_tag_filters=py37 python/ray/tune/...
# There are no python 3.7 tests for RaySGD/Docs at the moment
# There are no python 3.7 tests for RaySGD at the moment
# - ./ci/keep_alive bazel test --config=ci --build_tests_only --test_tag_filters=py37 python/ray/util/sgd/...
# - ./ci/keep_alive bazel test --config=ci --build_tests_only --test_tag_filters=py37 doc/...

Expand Down
10 changes: 10 additions & 0 deletions ci/travis/determine_tests_to_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def list_changed_files(commit_range):
RAY_CI_STREAMING_JAVA_AFFECTED = 0
RAY_CI_DASHBOARD_AFFECTED = 0
RAY_CI_DOCKER_AFFECTED = 0
RAY_CI_DOC_AFFECTED = 0

event_type = None
for key in ["GITHUB_EVENT_NAME", "TRAVIS_EVENT_TYPE"]:
Expand All @@ -70,6 +71,7 @@ def list_changed_files(commit_range):

for changed_file in files:
if changed_file.startswith("python/ray/tune"):
RAY_CI_DOC_AFFECTED = 1
RAY_CI_TUNE_AFFECTED = 1
RAY_CI_RLLIB_AFFECTED = 1
RAY_CI_RLLIB_FULL_AFFECTED = 1
Expand Down Expand Up @@ -100,11 +102,15 @@ def list_changed_files(commit_range):
RAY_CI_LINUX_WHEELS_AFFECTED = 1
RAY_CI_MACOS_WHEELS_AFFECTED = 1
RAY_CI_STREAMING_PYTHON_AFFECTED = 1
RAY_CI_DOC_AFFECTED = 1
elif changed_file.startswith("java/"):
RAY_CI_JAVA_AFFECTED = 1
RAY_CI_STREAMING_JAVA_AFFECTED = 1
elif changed_file.startswith("docker/"):
RAY_CI_DOCKER_AFFECTED = 1
elif changed_file.startswith("doc/") and changed_file.endswith(
".py"):
RAY_CI_DOC_AFFECTED = 1
elif any(
changed_file.startswith(prefix)
for prefix in skip_prefix_list):
Expand All @@ -123,6 +129,7 @@ def list_changed_files(commit_range):
RAY_CI_STREAMING_PYTHON_AFFECTED = 1
RAY_CI_STREAMING_JAVA_AFFECTED = 1
RAY_CI_DASHBOARD_AFFECTED = 1
RAY_CI_DOC_AFFECTED = 1
elif changed_file.startswith("streaming/src"):
RAY_CI_STREAMING_CPP_AFFECTED = 1
RAY_CI_STREAMING_PYTHON_AFFECTED = 1
Expand All @@ -138,6 +145,7 @@ def list_changed_files(commit_range):
RAY_CI_SERVE_AFFECTED = 1
RAY_CI_JAVA_AFFECTED = 1
RAY_CI_PYTHON_AFFECTED = 1
RAY_CI_DOC_AFFECTED = 1
RAY_CI_LINUX_WHEELS_AFFECTED = 1
RAY_CI_MACOS_WHEELS_AFFECTED = 1
RAY_CI_STREAMING_CPP_AFFECTED = 1
Expand All @@ -151,6 +159,7 @@ def list_changed_files(commit_range):
RAY_CI_SERVE_AFFECTED = 1
RAY_CI_JAVA_AFFECTED = 1
RAY_CI_PYTHON_AFFECTED = 1
RAY_CI_DOC_AFFECTED = 1
RAY_CI_LINUX_WHEELS_AFFECTED = 1
RAY_CI_MACOS_WHEELS_AFFECTED = 1
RAY_CI_STREAMING_CPP_AFFECTED = 1
Expand All @@ -174,6 +183,7 @@ def list_changed_files(commit_range):
"RAY_CI_RLLIB_FULL_AFFECTED={}".format(RAY_CI_RLLIB_FULL_AFFECTED),
"RAY_CI_SERVE_AFFECTED={}".format(RAY_CI_SERVE_AFFECTED),
"RAY_CI_DASHBOARD_AFFECTED={}".format(RAY_CI_DASHBOARD_AFFECTED),
"RAY_CI_DOC_AFFECTED={}".format(RAY_CI_DOC_AFFECTED),
"RAY_CI_JAVA_AFFECTED={}".format(RAY_CI_JAVA_AFFECTED),
"RAY_CI_PYTHON_AFFECTED={}".format(RAY_CI_PYTHON_AFFECTED),
"RAY_CI_LINUX_WHEELS_AFFECTED={}".format(RAY_CI_LINUX_WHEELS_AFFECTED),
Expand Down
2 changes: 1 addition & 1 deletion doc/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,5 @@ py_test(
main = "source/tune/_tutorials/tune-serve-integration-mnist.py",
srcs = ["source/tune/_tutorials/tune-serve-integration-mnist.py"],
tags = ["exclusive", "example"],
args = ["--smoke-test", "--from-scratch", "--day 0"]
args = ["--smoke-test", "--from_scratch", "--day 0"]
)

0 comments on commit 328b450

Please sign in to comment.