SAK-44597 Rubrics: Error in console sorting rubrics (sakaiproject#8764)

mrmodise · Nov 4, 2020 · 4114fd7 · 4114fd7
1 parent 49b93bc
commit 4114fd7
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubrics-manager.js b/webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubrics-manager.js
@@ -142,12 +142,15 @@ class SakaiRubricsManager extends RubricsElement {
   }
 
   sortRubrics(event) {
-    const sortInput = event.target.className;
-    const sortInputValue = sortInput.toString().toLowerCase();
-    const rubric = sortInputValue.split('-');
-    const rubricClass = rubric[0];
-    const rubricType = rubric[1];
-    const query = `.${sortInputValue}.sort-element-${rubricClass}`;
+
+    const sortInput = event.target.className.toLowerCase();
+
+    if (!sortInput) {
+      return;
+    }
+
+    const [rubricClass, rubricType] = sortInput.split("-");
+    const query = `.${sortInput}.sort-element-${rubricClass}`;
     const arrowUpIcon = 'fa-chevron-up';
     const arrowDownIcon = 'fa-chevron-down';
     let ascending = this.querySelector(query).classList.contains(arrowUpIcon);