SAK-40190: Rubric rows - even when the same - are not lined up (sakai…

…project#7298)
mrmodise · Sep 26, 2019 · 7cf08f5 · 7cf08f5
1 parent 0abb625
commit 7cf08f5
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 4 deletions.
diff --git a/library/src/morpheus-master/sass/modules/tool/rubrics/_rubrics.scss b/library/src/morpheus-master/sass/modules/tool/rubrics/_rubrics.scss
@@ -12,6 +12,14 @@
 
     .rubric-item {
         position: relative;
+        .div-description{
+            overflow: hidden;
+            text-overflow: ellipsis;
+        }
+
+        .cr-table{
+            table-layout: fixed;
+        }
     }
 
     .rubric-title {
@@ -167,7 +175,16 @@
             display: table;
             border: $rubrics-crit-border-size solid $rubrics-crit-border-color;
             border-width: $rubrics-crit-border-size 0 0 0;
-
+
+            .div-description{
+                overflow: hidden;
+                text-overflow: ellipsis;
+            }
+
+            .cr-table{
+                table-layout: fixed;
+            }
+
             &.sortable-ghost, .sortable-ghost {
                 opacity: 0.25;
             }

diff --git a/rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-criteria.js b/rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-criteria.js
@@ -70,9 +70,11 @@ export class SakaiRubricCriteria extends RubricsElement {
                   ${r.title}
                   <sakai-rubric-criterion-rating-edit criterion-id="${c.id}" @save-rating="${this.saveRating}" @delete-rating="${this.deleteRating}" minpoints="${c.pointrange ? c.pointrange.low : 0}" maxpoints="${c.pointrange ? c.pointrange.high : 0}" rating="${JSON.stringify(r)}"></sakai-rubric-criterion-rating-edit>
                 </h5>
-                <p>
+                <div class="div-description">
+                  <p>
                   ${r.description}
-                </p>
+                  </p>
+                </div>
                 <span class="points">
                   ${r.points} <sr-lang key="points">Points</sr-lang>
                 </span>

diff --git a/rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-criterion-preview.js b/rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-criterion-preview.js
@@ -26,7 +26,9 @@ export class SakaiRubricCriterionPreview extends RubricsElement {
                 ${c.ratings.map(r => html`
                   <div class="rating-item" id="rating_item_${r.id}" >
                     <h5 class="criterion-item-title">${r.title}</h5>
-                    <p>${r.description}</p>
+                    <div class="div-description">
+                      <p>${r.description}</p>
+                    </div>
                     <span class="points">
                       ${r.points} <sr-lang key="points">Points</sr-lang>
                     </span>