module: Simplify module_load()

The file path is not used for error reporting, so we can free it directly after use. Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Andreas Färber <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
mslovy · Jul 18, 2014 · f9e13f8 · f9e13f8
1 parent f52b768
commit f9e13f8
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/util/module.c b/util/module.c
@@ -202,18 +202,16 @@ static void module_load(module_init_type type)
         for (i = 0; i < ARRAY_SIZE(dirs); i++) {
             fname = g_strdup_printf("%s/%s%s", dirs[i], *mp, HOST_DSOSUF);
             ret = module_load_file(fname);
+            g_free(fname);
+            fname = NULL;
             /* Try loading until loaded a module file */
             if (!ret) {
                 break;
             }
-            g_free(fname);
-            fname = NULL;
         }
         if (ret == -ENOENT) {
             fprintf(stderr, "Can't find module: %s\n", *mp);
         }
-
-        g_free(fname);
     }
 
     for (i = 0; i < ARRAY_SIZE(dirs); i++) {