remove time.Sleep from tests (cadence-workflow#5489)

common/cache/lru_test.go

@@ -94,10 +94,17 @@ func TestLRUWithTTL(t *testing.T) {
 	cache := New(&Options{
 		MaxCount: 5,
 		TTL:      time.Millisecond * 100,
-	})
+	}).(*lru)
+
+	// We will capture this in the caches now function, and advance time as needed
+	currentTime := time.UnixMilli(0)
+	cache.now = func() time.Time { return currentTime }
+
 	cache.Put("A", "foo")
 	assert.Equal(t, "foo", cache.Get("A"))
-	time.Sleep(time.Millisecond * 300)
+
+	currentTime = currentTime.Add(time.Millisecond * 300)
+
 	assert.Nil(t, cache.Get("A"))
 	assert.Equal(t, 0, cache.Size())
 }
@@ -189,18 +196,23 @@ func TestRemovedFuncWithTTL(t *testing.T) {
 			assert.True(t, ok)
 			ch <- true
 		},
-	})
+	}).(*lru)
+
+	// We will capture this in the caches now function, and advance time as needed
+	currentTime := time.UnixMilli(0)
+	cache.now = func() time.Time { return currentTime }
 
 	cache.Put("A", t)
 	assert.Equal(t, t, cache.Get("A"))
-	time.Sleep(time.Millisecond * 100)
+
+	currentTime = currentTime.Add(time.Millisecond * 100)
+
 	assert.Nil(t, cache.Get("A"))
 
-	timeout := time.NewTimer(time.Millisecond * 300)
 	select {
 	case b := <-ch:
 		assert.True(t, b)
-	case <-timeout.C:
+	case <-time.After(100 * time.Millisecond):
 		t.Error("RemovedFunc did not send true on channel ch")
 	}
 }
@@ -216,24 +228,27 @@ func TestRemovedFuncWithTTL_Pin(t *testing.T) {
 			assert.True(t, ok)
 			ch <- true
 		},
-	})
+	}).(*lru)
+
+	// We will capture this in the caches now function, and advance time as needed
+	currentTime := time.UnixMilli(0)
+	cache.now = func() time.Time { return currentTime }
 
 	_, err := cache.PutIfNotExist("A", t)
 	assert.NoError(t, err)
 	assert.Equal(t, t, cache.Get("A"))
-	time.Sleep(time.Millisecond * 100)
+	currentTime = currentTime.Add(time.Millisecond * 100)
 	assert.Equal(t, t, cache.Get("A"))
 	// release 3 time since put if not exist also increase the counter
 	cache.Release("A")
 	cache.Release("A")
 	cache.Release("A")
 	assert.Nil(t, cache.Get("A"))
 
-	timeout := time.NewTimer(time.Millisecond * 300)
 	select {
 	case b := <-ch:
 		assert.True(t, b)
-	case <-timeout.C:
+	case <-time.After(300 * time.Millisecond):
 		t.Error("RemovedFunc did not send true on channel ch")
 	}
 }