Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable mt.exe on macOS with Wine 9.0 #104

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

huangqinjin
Copy link
Contributor

mt.exe no longer crashes on macOS with Wine 9.0.

macOS-12 runner image version 20240119 has updated to Wine 9.0.
https://github.com/huangqinjin/msvc-wine/actions/runs/7583317817/job/20752571482

Let's wait until most runners have been upgraded.

@mstorsjo
Copy link
Owner

mt.exe no longer crashes on macOS with Wine 9.0.

That's good news, thanks!

macOS-12 runner image version 20240119 has updated to Wine 9.0. https://github.com/huangqinjin/msvc-wine/actions/runs/7583317817/job/20752571482

Let's wait until most runners have been upgraded.

This is weird - as Wine itself isn't shipped as part of the runner install, but we install it from brew, I wouldn't expect that the runner version itself should matter. Or does it depend on how old brew package listing cache there is in the base install? Can we do something like brew update or similar (untested) to make sure we get the latest Wine consistently, for now until all active runners have a new enough brew package cache?

@huangqinjin huangqinjin force-pushed the enable-mt-on-macos-wine-9.0 branch from e5faeb9 to 57ed631 Compare January 25, 2024 13:44
@huangqinjin
Copy link
Contributor Author

Yes, brew update works!

@mstorsjo
Copy link
Owner

Yes, brew update works!

Thanks, this looks good to me. I testran brew update && brew install wine-stable a couple times, so I got a runner with an older OS image, and I still got wine 9.0, so this seems to work as expected.

@mstorsjo mstorsjo merged commit 9e9ae8b into mstorsjo:master Jan 25, 2024
4 checks passed
@huangqinjin huangqinjin deleted the enable-mt-on-macos-wine-9.0 branch January 26, 2024 00:31
@mstorsjo
Copy link
Owner

FWIW, the brew update stage seems to break installing meson (which installs python) in current versions - see https://github.com/mstorsjo/msvc-wine/actions/runs/7902146137/job/21567372457.

It's reproducible with something as little as brew update && brew install meson.

It's not clear to me if this is a generic homebrew issue (I don't see any reports about the same in homebrew), or if it is caused by something else installed on the github actions runners, that conflicts with homebrew's python when it tries to update it. It does seem to happen with both macos-12 and macos-13 runners (which both are x86), but not with macos-14 (which is arm64). AFAIK macos-latest currently actually still points at macos-12.

@mstorsjo
Copy link
Owner

FWIW, the brew update stage seems to break installing meson (which installs python) in current versions - see https://github.com/mstorsjo/msvc-wine/actions/runs/7902146137/job/21567372457.

It's reproducible with something as little as brew update && brew install meson.

It's not clear to me if this is a generic homebrew issue (I don't see any reports about the same in homebrew), or if it is caused by something else installed on the github actions runners, that conflicts with homebrew's python when it tries to update it. It does seem to happen with both macos-12 and macos-13 runners (which both are x86), but not with macos-14 (which is arm64). AFAIK macos-latest currently actually still points at macos-12.

I can somewhat work around this, by installing software in two stages; first brew install msitools cmake ninja meson, followed by brew update and brew install wine-stable. This works on macos-12 runners, but on macos-13 runners, even this procedure seems to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants