Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsdownload: Use id in dependencies if exists #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huangqinjin
Copy link
Contributor

Observed that starting with VS 17.12, package Microsoft.VisualStudio.PackageGroup.VsDevCmd is missing
https://github.com/mstorsjo/msvc-wine/actions/runs/11948558852/job/33306358321#step:4:42, compared to VS 17.11
https://github.com/mstorsjo/msvc-wine/actions/runs/11427400934/job/31791489553#step:4:39.

Checked dependencies with their manifests,

  • 17.11:
Microsoft.VisualStudio.Workload.VCTools
  Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core
    Microsoft.VisualStudio.PackageGroup.VC.CoreIDE.Reduced
      Microsoft.VisualStudio.PackageGroup.Core
        Microsoft.VisualStudio.PackageGroup.CoreEditor
          Microsoft.VisualStudio.PackageGroup.VsDevCmd
  • 17.12:
Microsoft.VisualStudio.Workload.VCTools
  Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core
    Microsoft.VisualStudio.PackageGroup.VC.CoreIDE.Reduced
      Microsoft.VisualStudio.PackageGroup.Core
        Microsoft.VisualStudio.PackageGroup.CoreEditor
          Microsoft.VisualStudio.PackageGroup.VsDevCmd_-137610554 (NotFound)

And the dependency constraint contains a id field. So I believe it should be used, though I don't know what the numbers after the package name mean.

{
  "id": "Microsoft.VisualStudio.PackageGroup.CoreEditor",
  "dependencies": {
    "Microsoft.VisualStudio.PackageGroup.VsDevCmd_-137610554": {
      "id": "Microsoft.VisualStudio.PackageGroup.VsDevCmd",
      "version": "[17.0,18.0)",
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant