Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open() manifest savefile in binary mode to make it work with Python 3 #16

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

imaami
Copy link
Contributor

@imaami imaami commented Jul 15, 2020

Fixes the following error:

$ ./vsdownload.py --save-manifest
Fetching https://aka.ms/vs/16/release/channel
Got toplevel manifest for 16.6.4
Loaded installer manifest for 16.6.4
Traceback (most recent call last):
  File "./vsdownload.py", line 505, in <module>
    packages = getPackages(getManifest(args))
  File "./vsdownload.py", line 150, in getManifest
    f.write(manifestdata)
TypeError: write() argument must be str, not bytes

Signed-off-by: Juuso Alasuutari [email protected]

@mstorsjo mstorsjo merged commit 41b318d into mstorsjo:master Jul 15, 2020
@mstorsjo
Copy link
Owner

Thanks!

@imaami imaami deleted the python3-save-manifest-wb branch July 16, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants