vsdownload: Allow dest dir to contain spaces on Windows #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstorsjo
reviewed
Dec 30, 2024
| @@ -587,7 +587,8 @@ def unpackWin10SDK(src, payloads, dest): | |||
| print("Extracting " + name) | |||
| srcfile = os.path.join(src, name) | |||
| if sys.platform == "win32": | |||
| cmd = ["msiexec", "/a", srcfile, "/qn", "TARGETDIR=" + os.path.abspath(dest)] | |||
| # The path to TARGETDIR need to be quoted in the case of spaces. | |||
| cmd = "msiexec /a \"%s\" /qn TARGETDIR=\"%s\"" % (srcfile, os.path.abspath(dest)) | |||
There was a problem hiding this comment.
Hmm, so is this a case where the python subprocess.check_call() taking an array cmd actually doesn't quote the individual arguments correctly when they contain spaces? (I know there are hairy corner cases when it comes to quoting of special characters, but for something as straightforward as regular spaces, I would have expected the usual array form to work.)
There was a problem hiding this comment.
Btw, for this change, it makes me think that it would be valuable to have CI testing using vsdownload.py on Windows too, to have test coverage of these codepaths. After downloading and unpacking, I wonder what trivial verification we could do on it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.