Skip to content

Commit

Permalink
Remove sigma point calc from UKF update (fixes mherb#3)
Browse files Browse the repository at this point in the history
For the update step, the sigma points computed in the preceding prediction step are used and not re-calculated. Thanks to zy041984 for pointing this out!
  • Loading branch information
mherb committed Dec 16, 2017
1 parent fd9bc73 commit 7973005
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
3 changes: 0 additions & 3 deletions include/kalman/SquareRootUnscentedKalmanFilter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,6 @@ namespace Kalman {
{
SigmaPoints<Measurement> sigmaMeasurementPoints;

// Compute sigma points (using predicted state)
computeSigmaPoints();

// Predict measurement (and corresponding sigma points)
Measurement y = this->template computeMeasurementPrediction<Measurement, CovarianceBase>(m, sigmaMeasurementPoints);

Expand Down
7 changes: 0 additions & 7 deletions include/kalman/UnscentedKalmanFilter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,6 @@ namespace Kalman {
{
SigmaPoints<Measurement> sigmaMeasurementPoints;

// Compute sigma points (using predicted state)
if(!computeSigmaPoints())
{
// TODO: handle numerical error
assert(false);
}

// Predict measurement (and corresponding sigma points)
Measurement y = this->template computeMeasurementPrediction<Measurement, CovarianceBase>(m, sigmaMeasurementPoints);

Expand Down

0 comments on commit 7973005

Please sign in to comment.