Add stylua selection version command

stylua-vscode/CHANGELOG.md

@@ -15,6 +15,7 @@ To view the changelog of the StyLua binary, see [here](https://github.com/Johnny
 
 - Added configuration option `stylua.configPath` to provide a direct path to a `stylua.toml` file. Note: this will override any workspace config lookup
 - Added configuration option `stylua.verify` to pass `--verify` to StyLua CLI when formatting a file. This enforces output verification
+- Added command `StyLua: Select Version` to customize which version of StyLua to install. This command updates the `stylua.targetReleaseVersion` setting
 
 ### Changed
 

stylua-vscode/package.json

@@ -47,6 +47,11 @@
         "command": "stylua.showOutputChannel",
         "title": "Show Output Channel",
         "category": "StyLua"
+      },
+      {
+        "command": "stylua.selectVersion",
+        "title": "Select Version",
+        "category": "StyLua"
       }
     ],
     "configuration": {
@@ -142,6 +147,7 @@
   "dependencies": {
     "ignore": "^5.1.8",
     "node-fetch": "^2.6.1",
+    "semver": "^7.5.4",
     "unzipper": "^0.10.14"
   }
 }

stylua-vscode/src/download.ts

@@ -17,7 +17,7 @@ export class StyluaDownloader {
 
     if (path === undefined) {
       await vscode.workspace.fs.createDirectory(this.storageDirectory);
-      await this.downloadStyLuaVisual();
+      await this.downloadStyLuaVisual(util.getDesiredVersion());
       return await this.getStyluaPath();
     } else {
       if (!(await util.fileExists(path))) {
@@ -69,19 +69,18 @@ export class StyluaDownloader {
     }
   }
 
-  public downloadStyLuaVisual(): Thenable<void> {
+  public downloadStyLuaVisual(version: string): Thenable<void> {
     return vscode.window.withProgress(
       {
         cancellable: false,
         location: vscode.ProgressLocation.Notification,
-        title: "Downloading StyLua",
+        title: `Downloading StyLua (${version})`,
       },
-      () => this.downloadStylua()
+      () => this.downloadStylua(version)
     );
   }
 
-  private async downloadStylua(): Promise<void> {
-    const version = util.getDesiredVersion();
+  private async downloadStylua(version: string): Promise<void> {
     const release = await this.github.getRelease(version);
     const assetFilename = util.getAssetFilenamePattern();
     const outputFilename = util.getDownloadOutputFilename();
@@ -129,7 +128,7 @@ export class StyluaDownloader {
       .then((option) => {
         switch (option) {
           case "Install":
-            this.downloadStyLuaVisual();
+            this.downloadStyLuaVisual(release.tagName);
             break;
           case "Release Notes":
             vscode.env.openExternal(vscode.Uri.parse(release.htmlUrl));

stylua-vscode/src/extension.ts

@@ -1,7 +1,9 @@
 import * as vscode from "vscode";
+import * as semver from "semver";
 import { formatCode, checkIgnored } from "./stylua";
 import { GitHub } from "./github";
 import { StyluaDownloader } from "./download";
+import { getDesiredVersion } from "./util";
 
 /**
  * Convert a Position within a Document to a byte offset.
@@ -42,7 +44,7 @@ export async function activate(context: vscode.ExtensionContext) {
 
   context.subscriptions.push(
     vscode.commands.registerCommand("stylua.reinstall", async () => {
-      await downloader.downloadStyLuaVisual();
+      await downloader.downloadStyLuaVisual(getDesiredVersion());
       styluaBinaryPath = await downloader.getStyluaPath();
     })
   );
@@ -59,6 +61,47 @@ export async function activate(context: vscode.ExtensionContext) {
     })
   );
 
+  context.subscriptions.push(
+    vscode.commands.registerCommand("stylua.selectVersion", async () => {
+      const versions = (await github.getAllReleases()).sort((a, b) =>
+        semver.rcompare(a.tagName, b.tagName)
+      );
+      if (versions.length === 0) {
+        return;
+      }
+      const latestVersion = versions[0];
+
+      const selectedVersion = await vscode.window.showQuickPick(
+        versions
+          .sort((a, b) => semver.rcompare(a.tagName, b.tagName))
+          .map((release) => {
+            if (release.tagName === latestVersion.tagName) {
+              return { label: `${release.tagName} (latest)` };
+            } else {
+              return { label: release.tagName };
+            }
+          }),
+        {
+          placeHolder: "Select the version of StyLua to install",
+        }
+      );
+
+      if (selectedVersion) {
+        const updateConfigValue = selectedVersion.label.includes("latest")
+          ? "latest"
+          : selectedVersion.label;
+        await downloader.downloadStyLuaVisual(selectedVersion.label);
+        vscode.workspace
+          .getConfiguration("stylua")
+          .update(
+            "targetReleaseVersion",
+            updateConfigValue,
+            vscode.ConfigurationTarget.Workspace
+          );
+      }
+    })
+  );
+
   context.subscriptions.push(
     vscode.workspace.onDidChangeConfiguration(async (change) => {
       if (change.affectsConfiguration("stylua")) {
@@ -100,7 +143,7 @@ export async function activate(context: vscode.ExtensionContext) {
             )
             .then((option) => {
               if (option === "Install") {
-                downloader.downloadStyLuaVisual();
+                vscode.commands.executeCommand("stylua.reinstall");
               }
             });
           return [];

stylua-vscode/src/github.ts

@@ -132,17 +132,19 @@ export class GitHub implements Disposable {
     return this.credential.authenticated;
   }
 
+  public async getAllReleases(): Promise<GitHubRelease[]> {
+    const json = await fetchJson(RELEASES_URL, this.credential.token);
+    return Array.isArray(json) ? json.map(releaseFromJson) : [];
+  }
+
   public async getRelease(version: string): Promise<GitHubRelease> {
     if (version === "latest") {
       const json = await fetchJson(RELEASES_URL_LATEST, this.credential.token);
       return releaseFromJson(json);
     }
 
     version = version.startsWith("v") ? version : "v" + version;
-    const json = await fetchJson(RELEASES_URL, this.credential.token);
-    const releases: GitHubRelease[] = Array.isArray(json)
-      ? json.map(releaseFromJson)
-      : [];
+    const releases = await this.getAllReleases();
     for (const release of releases) {
       if (release.tagName.startsWith(version)) {
         return release;