Fix an issue where public builds always show on initial load. (travis…

…-ci#2012) * Fix an issue where public builds always show on initial load. * Use ember concurrency
mtoothman · Apr 15, 2019 · f6dba49 · f6dba49
1 parent 7125ae8
commit f6dba49
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/app/controllers/owner/repositories.js b/app/controllers/owner/repositories.js
@@ -1,6 +1,6 @@
 import Controller from '@ember/controller';
 import { inject as service } from '@ember/service';
-import { and, equal } from '@ember/object/computed';
+import { and, equal, bool } from '@ember/object/computed';
 import { DEFAULT_INSIGHTS_INTERVAL } from 'travis/services/insights';
 
 export const OWNER_TABS = {
@@ -29,7 +29,8 @@ export default Controller.extend({
   reposLoading: equal('repos', null),
 
   builds: null,
-  buildsLoading: equal('builds', null),
+  buildsReady: bool('builds.isFinished'),
+
 
   actions: {
     setRequestPrivateInsights(val) {

diff --git a/app/templates/owner/repositories.hbs b/app/templates/owner/repositories.hbs
@@ -11,7 +11,7 @@
 
 <div class="owner-repo">
   {{#if isInsights}}
-    {{#unless buildsLoading}}
+    {{#if buildsReady}}
       <div class="travistab-body">
         <div class="insights-controls">
           <div class="insights-controls-left">
@@ -38,7 +38,7 @@
       </div>
     {{else}}
       {{loading-screen center=true margin=true}}
-    {{/unless}}
+    {{/if}}
   {{else}}
     {{#unless reposLoading}}
       <ul class="owner-tiles">